Conversation
- Added consistent padding for log level field in logs. - Introduced unit test `Logger_LogLevel_Padding_Is_Consistent` to verify padding. - Modified log formatting in `Logging.cs` to ensure 5-character width for log levels. - Updated `AssemblyInfo.cs` to version 1.1.1.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds consistent padding for log level fields to improve log formatting readability and bumps the version to 1.1.1.
- Modified log formatting to pad log levels to 5 characters for consistent alignment
- Added comprehensive unit test to verify log level padding behavior
- Updated version numbers and changelog documentation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| SerpentModding/Properties/AssemblyInfo.cs | Updated assembly version from 1.1.0 to 1.1.1 |
| SerpentModding/Logging.cs | Added PadRight(5) formatting to log level strings |
| SerpentModding.Tests/UnitTest.cs | Added unit test to verify consistent 5-character padding for all log levels |
| CHANGELOG.md | Added changelog entry for version 1.1.1 with padding feature description |
Comment on lines
+2
to
+3
| - Logger: Einheitliche Padding-Formatierung f�r das LogLevel-Feld im Log eingef�hrt, sodass alle Level (z.B. INFO, FATAL) gleich breit erscheinen. | ||
| - Logger: Unittest erg�nzt, der pr�ft, dass das LogLevel im Log immer auf 5 Zeichen gepaddet ist. |
There was a problem hiding this comment.
Changelog entry contains German text and character encoding issues (erg�nzt, pr�ft). Consider using English: '- Logger: Added unit test that verifies LogLevel in logs is always padded to 5 characters.'
Suggested change
| - Logger: Einheitliche Padding-Formatierung f�r das LogLevel-Feld im Log eingef�hrt, sodass alle Level (z.B. INFO, FATAL) gleich breit erscheinen. | |
| - Logger: Unittest erg�nzt, der pr�ft, dass das LogLevel im Log immer auf 5 Zeichen gepaddet ist. | |
| - Logger: Introduced uniform padding formatting for the LogLevel field in logs, ensuring all levels (e.g., INFO, FATAL) appear with equal width. | |
| - Logger: Added unit test that verifies the LogLevel in logs is always padded to 5 characters. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Serpensin
added a commit
that referenced
this pull request
Jul 29, 2025
Update to version 1.1.1 with log level padding (#13)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logger_LogLevel_Padding_Is_Consistentto verify padding.Logging.csto ensure 5-character width for log levels.AssemblyInfo.csto version 1.1.1.