Propulsion Model Improvements: Efficiency & Autotune Alignment#2
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the propulsion modeling outputs by adding propeller/motor/system efficiency to OperatingPoint, aligns the motor calibration math in autotune.py with the solver’s 2nd-order (Drela-style) motor model, and adds tests to validate the new efficiency outputs.
Changes:
- Added
propeller_efficiency,motor_efficiency, andsystem_efficiencyfields toOperatingPointand computed them inPropulsionSolver. - Updated
PropulsionCalibratormotor electrical model to match the solver (magnetic lag back-EMF, speed-dependent no-load current, current-dependent winding resistance, battery discharge efficiency). - Added/updated unit tests and expanded
.gitignoreto exclude coverage and pytest cache artifacts.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
pythrust/propulsion/solver.py |
Computes and returns new efficiency outputs on each solved operating point. |
pythrust/propulsion/models.py |
Extends OperatingPoint with three efficiency fields (defaulting to 0.0). |
pythrust/propulsion/autotune.py |
Aligns calibration motor physics with solver (2nd-order model + battery discharge efficiency). |
tests/test_solver.py |
Adds solver efficiency tests for static and dynamic conditions. |
tests/test_models.py |
Updates OperatingPoint construction tests for new fields and defaults. |
.gitignore |
Ignores coverage and pytest cache outputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…alculations fix(tests): update efficiency assertions to allow equality with 1.0 and add invalid efficiency test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's done in this PR:
OperatingPointand implemented their calculations insolver.pyautotune.pywithsolver.pyby incorporating 2nd-order Drela model math (magnetic lag, speed-dependent no-load current, quadratic winding resistance, and battery discharge efficiency).gitignoreto prevent tracking.coverageand pytest cache files