Skip to content

Update project to be able to build with Xcode 15#29

Draft
faisal wants to merge 2 commits into
Sh1d0w:masterfrom
faisal:deployment_target_10_15
Draft

Update project to be able to build with Xcode 15#29
faisal wants to merge 2 commits into
Sh1d0w:masterfrom
faisal:deployment_target_10_15

Conversation

@faisal
Copy link
Copy Markdown

@faisal faisal commented Oct 26, 2023

A number of changes in support of being able to build with the current Xcode:

  • Set all targets' build version, marketing version, and swift version to inherit from the project. With the minimum deployment target of 10.15 and use of Swift 5, Xcode no longer bundles Swift libraries in the built app for backwards compatibility, which cuts the resulting app size by ~90%.
  • Stopped manually embedding the Clean_Links entitlement

@faisal
Copy link
Copy Markdown
Author

faisal commented Oct 26, 2023

This is largely ready, but it builds on #28 and we should wait for that to land before landing this one.

@faisal faisal mentioned this pull request Oct 26, 2023
Have all targets use the project's macOS deployment target, bundle version, and Swift version. This restores the ability to build using Xcode 15, shrinks the package size substantially (since we no longer need to bundle the Swift libraries in the app), and should make it easier to allow future development since we no longer need to chase down target setting mismatches.
@faisal faisal force-pushed the deployment_target_10_15 branch from 4d31cf0 to 630974b Compare October 27, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant