Migration to Swift 5

[mariojuni]

migrate to swift5

[jayhickey]

+1 to this, would love to get it updated to Swift 5! I think there's one additional spot where internal can be removed:

XMLParsing/Sources/XMLParsing/Encoder/EncodingErrorExtension.swift

Line 21 in fc91ba3

internal static func _invalidFloatingPointValue<T : FloatingPoint>(_ value: T, at codingPath: [CodingKey]) -> EncodingError {

[mariojuni]

thank you!

[MaxDesiatov]

Hi @jayhickey and @maryow777, I maintain a compatible fork of this package called XMLCoder, it supports and is tested with Swift 5 and Xcode 10.2. It looks like XMLParsing is no longer maintained, but you should be able to migrate to XMLCoder without any significant changes to your existing codebase.

[mariojuni]

okay just send as the link so that we will contribute :)

…

On Wed, May 1, 2019, 7:44 PM Max Desiatov ***@***.***> wrote: Hi @jayhickey <https://github.com/jayhickey> and @maryow777 <https://github.com/maryow777>, I maintain a compatible fork of this package called XMLCoder <https://github.com/MaxDesiatov/XMLCoder>, it supports and is tested with Swift 5 and Xcode 10.2. It looks like XMLParsing is no longer maintained, but you should be able to migrate to XMLCoder without any significant changes to your existing codebase. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#42 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHQBJPEFGFKJFVVRLKJXUULPTF7BLANCNFSM4HBLXTOQ> .

[MaxDesiatov]

@maryow777 sure, the link is in my previous comment, any contributions are very welcome!