fix: normalise legacy items missing mark/modifiers fields on load#1
Open
raman78 wants to merge 1 commit intoShinga13:mainfrom
Open
fix: normalise legacy items missing mark/modifiers fields on load#1raman78 wants to merge 1 commit intoShinga13:mainfrom
raman78 wants to merge 1 commit intoShinga13:mainfrom
Conversation
Builds saved before the mark/modifiers fields were introduced crash when loaded because slot_equipment_item (via add_equipment_tooltip_header) expects these keys to be present. Add setdefault guards in load_equipment_cat so old saves are silently upgraded on the first load — no data is lost, the fields are just initialised to their default empty values. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds saved before the `mark`/`modifiers` fields were introduced crash when loaded because `slot_equipment_item` (via `add_equipment_tooltip_header`) expects these keys to be present.
Add `setdefault` guards in `load_equipment_cat` so old saves are silently upgraded on first load — no data is lost, the fields are initialised to their default empty values.