Skip to content

Drop dependency on posix-spawn #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianks merged 1 commit into from
Mar 19, 2024
Merged

Drop dependency on posix-spawn #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion binaryen.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,4 @@ Gem::Specification.new do |spec|
spec.homepage = "https://github.com/Shopify/binaryen-rb"
spec.platform = Gem::Platform::RUBY
spec.extensions = ["extconf.rb"]
spec.add_dependency("posix-spawn", "~> 0.3.15")
end
4 changes: 1 addition & 3 deletions lib/binaryen/command.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
# frozen_string_literal: true

require "posix/spawn"
require "timeout"
require "tempfile"

module Binaryen
class Command
include POSIX::Spawn
DEFAULT_MAX_OUTPUT_SIZE = 256 * 1024 * 1024 * 1024 # 256 MiB
DEFAULT_TIMEOUT = 10
DEFAULT_ARGS_FOR_COMMAND = {}.freeze
Expand Down Expand Up @@ -44,7 +42,7 @@ def spawn_command(*args, stderr: nil, stdin: nil)

File.open(File::NULL, "w") do |devnull|
IO.pipe do |err_read, err_write|
pid = POSIX::Spawn.pspawn(
pid = Process.spawn(
*args,
"--output=#{tmpfile.path}",
in_write.path,
Expand Down