Clarify filesystem testing guidance#7905
Open
alfonso-noriega wants to merge 1 commit into
Open
Conversation
Assisted-By: devx/35aa2b43-cb40-4048-859c-af48d6d3ca28
github-actions
Bot
added
the
no-changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
No issue; small documentation maintenance.
The filesystem testing guidance had an awkward sentence that could be read as recommending the opposite of the intended approach.
WHAT is this pull request doing?
Clarifies the testing strategy docs to recommend using temporary directories for filesystem I/O tests instead of stubbing the filesystem.
How to test your changes?
git diff --checkPost-release steps
None.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add