Skip to content

Wait an event loop turn in binary download test#7906

Open
alfonso-noriega wants to merge 1 commit into
mainfrom
06-23-remove_sleeps_from_binary_download_test
Open

Wait an event loop turn in binary download test#7906
alfonso-noriega wants to merge 1 commit into
mainfrom
06-23-remove_sleeps_from_binary_download_test

Conversation

@alfonso-noriega

@alfonso-noriega alfonso-noriega commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

No issue; test reliability maintenance.

The binary download concurrency test now avoids fixed sleeps on main, but it still uses a bare microtask flush before asserting that the second download remains blocked. Waiting for an explicit event-loop turn better matches the async filesystem boundary the test is exercising.

WHAT is this pull request doing?

Adds a small waitForNextEventLoopTurn test helper and uses it before asserting the second binary download has not resolved while the first download is still blocked.

How to test your changes?

  • pnpm test packages/app/src/cli/services/function/binaries.test.ts
  • pnpm --filter @shopify/app lint
  • pnpm --filter @shopify/app type-check

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

@alfonso-noriega alfonso-noriega requested a review from a team as a code owner June 23, 2026 14:13
@alfonso-noriega alfonso-noriega force-pushed the 06-23-remove_sleeps_from_binary_download_test branch from f557d89 to 8a75604 Compare June 23, 2026 14:19
@alfonso-noriega alfonso-noriega changed the title Remove sleeps from binary download test Wait an event loop turn in binary download test Jun 23, 2026
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant