Wait an event loop turn in binary download test#7906
Open
alfonso-noriega wants to merge 1 commit into
Open
Conversation
f557d89 to
8a75604
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
No issue; test reliability maintenance.
The binary download concurrency test now avoids fixed sleeps on
main, but it still uses a bare microtask flush before asserting that the second download remains blocked. Waiting for an explicit event-loop turn better matches the async filesystem boundary the test is exercising.WHAT is this pull request doing?
Adds a small
waitForNextEventLoopTurntest helper and uses it before asserting the second binary download has not resolved while the first download is still blocked.How to test your changes?
pnpm test packages/app/src/cli/services/function/binaries.test.tspnpm --filter @shopify/app lintpnpm --filter @shopify/app type-checkPost-release steps
None.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add