[Tests] Remove filesystem mocks in doc fetch service tests#7908
[Tests] Remove filesystem mocks in doc fetch service tests#7908gonzaloriestra wants to merge 1 commit into
Conversation
Refactored `packages/cli/src/cli/services/commands/doc/fetch.test.ts` to replace filesystem mocks with real operations using `inTemporaryDirectory`. Verified that `docFetchService` correctly handles directory creation and file writing by asserting the state of the real filesystem.
- Replaced `vi.mock('@shopify/cli-kit/node/fs')` with real fs utilities.
- Updated 'writes the document to the output path instead of stdout' to use `inTemporaryDirectory`.
- Complied with `vitest/prefer-expect-resolves` ESLint rule.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
1 participant
Summary
This PR refactors the unit tests for the
docFetchServicein@shopify/clito eliminate filesystem mocks, following the testing guidelines for the repository.Changes
vi.mock('@shopify/cli-kit/node/fs')frompackages/cli/src/cli/services/commands/doc/fetch.test.ts.inTemporaryDirectoryand real filesystem assertions (fileExistsSync,readFile).vitest/prefer-expect-resolveslint rule by usingexpect().resolves.How to test your changes?
CI
PR created automatically by Jules for task 1843732053590101784 started by @gonzaloriestra