Skip to content

[Refactor] Use lookup map for global CLI install command #8342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gonzaloriestra wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Refactor] Use lookup map for global CLI install command #8342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions packages/cli-kit/src/public/node/upgrade.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,14 @@ import {CLI_KIT_VERSION} from '../common/version.js'

export {getAutoUpgradeEnabled, setAutoUpgradeEnabled}

const CLI_INSTALL_COMMANDS: Partial<Record<string, string>> = {
homebrew: 'brew upgrade shopify-cli',
yarn: 'yarn global add @shopify/cli@latest',
pnpm: 'pnpm add -g @shopify/cli@latest',
npm: 'npm install -g @shopify/cli@latest',
bun: 'bun install -g @shopify/cli@latest',
}

/**
* Utility function for generating an install command for the user to run
* to install an updated version of Shopify CLI.
Expand All @@ -29,16 +37,7 @@ export {getAutoUpgradeEnabled, setAutoUpgradeEnabled}
*/
export function cliInstallCommand(): string | undefined {
const packageManager = inferPackageManagerForGlobalCLI()
if (!packageManager || packageManager === 'unknown') return undefined

if (packageManager === 'homebrew') {
return 'brew upgrade shopify-cli'
} else if (packageManager === 'yarn') {
return `${packageManager} global add @shopify/cli@latest`
} else {
const verb = packageManager === 'pnpm' ? 'add' : 'install'
return `${packageManager} ${verb} -g @shopify/cli@latest`
}
return CLI_INSTALL_COMMANDS[packageManager]
}

/**
Expand Down
Loading