Skip to content

Use hide-when-empty as a class, so CSS will work correctly#35

Open
sippsolutions wants to merge 1 commit intoShopify:mainfrom
sippsolutions:FIX-CLASS
Open

Use hide-when-empty as a class, so CSS will work correctly#35
sippsolutions wants to merge 1 commit intoShopify:mainfrom
sippsolutions:FIX-CLASS

Conversation

@sippsolutions
Copy link

horizon/assets/base.css:488 lists

.hide-when-empty:empty {
  /* stylelint-disable-next-line declaration-no-important */
  display: none !important;
}

which will not work for the <span> which uses hide-when-empty as an attribute instead of a class.

Copy link

@brandtam brandtam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works and fixes a bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants