fix: optimize mobile product image sizing logic#43
Open
TonyStark wants to merge 1 commit intoShopify:mainfrom
Open
fix: optimize mobile product image sizing logic#43TonyStark wants to merge 1 commit intoShopify:mainfrom
TonyStark wants to merge 1 commit intoShopify:mainfrom
Conversation
Refactor image size logic in 'snippets/card-gallery.liquid' to dynamically calculate mobile viewport width based on 'section.settings.mobile_columns' and 'section.settings.mobile_product_card_size'. Now uses mathematical division (e.g., 100 / 2 = 50vw) to set the correct 'sizes' attribute, preventing the download of full-width (HD) images on 1-column and 2-column mobile grids. Update 'snippets/product-media.liquid' to include intermediate image widths (450, 533, 600, 720). This provides the browser with better candidates for high-density mobile screens, ensuring sharp images without unnecessary bandwidth usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor image size logic in 'snippets/card-gallery.liquid' to dynamically calculate mobile viewport width based on 'section.settings.mobile_columns' and 'section.settings.mobile_product_card_size'. Now uses mathematical division (e.g., 100 / 2 = 50vw) to set the correct 'sizes' attribute, preventing the download of full-width (HD) images on 1-column and 2-column mobile grids.