Serialize Active Record errored elements#1494
Merged
Merged
Conversation
Rails now deep-dups error report context for each subscriber, so passing an Active Record instance as errored_element can clear its primary key before subscribers serialize it. Serialize Active Record errored_element values before calling Rails.error.report while preserving non-Active Record values and the legacy error_handler path. Rails change: rails/rails@d9e293e
nvasilevski
approved these changes
Jun 3, 2026
that-jill
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails now deep-dups error report context for each subscriber, so passing an Active Record instance as
errored_elementcan clear its primary key before subscribers serialize it.This PR serialize the Active Record
errored_elementvalues before callingRails.error.report, while preserving non-Active Record values and the legacy handler path.Rails change: rails/rails@d9e293e
I'm opting not to branch based on the AR version (ie. deprecate calling the error reporter with the full AR object and branch on the new codepath), but we can go that route if preferred.