Add ActiveRecordCoder codec test with hard-coded payload#16
Merged
shioyama merged 1 commit intoAug 23, 2022
Merged
Conversation
shioyama
force-pushed
the
shioyama/add_hard_coded_activerecord_coder_codec_test
branch
from
f59d838 to
c03e8ca
Compare
shioyama
force-pushed
the
shioyama/add_hard_coded_activerecord_coder_codec_test
branch
2 times, most recently
from
9e5b056 to
f18ecd3
Compare
casperisfine
approved these changes
Aug 23, 2022
| end | ||
|
|
||
| test "preserves previous encoding scheme" do | ||
| payload = "\xC8\x01\x1A\x06\x95\x92\x00\x92\x92\xC7\x06\x00domain\x92\x01\x91\x92\xD6\x00shop\x00\x92\xD7\x00products\x92\x92\x02\x91\x92\xD6\x00shop\x00\x92\x03\x91\x92\xD6\x00shop\x00\x92\xA4Shop\x84\xA2id\x01\xA4name\xAASnow Devil\xA8settings\xC4\x18#\xE2\x98\xA01\xE2\x98\xA2\n\x81\xD7\x00currency\xA3\xE2\x82\xAC\xA8owner_id\xC0\x92\xA6Domain\x83\xA7shop_id\x01\xA2id\x01\xA4name\xABexample.com\x92\xA7Product\x84\xA7shop_id\x01\xA2id\x01\xA4name\xAFCheap Snowboard\xA8quantity\x18\x92\xA7Product\x84\xA7shop_id\x01\xA2id\x02\xA4name\xB3Expensive Snowboard\xA8quantity\x02".b # rubocop:disable Layout/LineLength |
Contributor
There was a problem hiding this comment.
Maybe split that line a bit? Or move it to a fixture file?
shioyama
force-pushed
the
shioyama/add_hard_coded_activerecord_coder_codec_test
branch
2 times, most recently
from
df2ba1d to
7f4618c
Compare
shioyama
force-pushed
the
shioyama/add_hard_coded_activerecord_coder_codec_test
branch
from
7f4618c to
31e2d14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #14 (comment)
Added test ensures that payloads generated when encoding records do not change.