Skip to content

Revert optional index_source language_id#856

Merged
st0012 merged 1 commit into
mainfrom
codex/revert-pr-changes
Jun 11, 2026
Merged

Revert optional index_source language_id#856
st0012 merged 1 commit into
mainfrom
codex/revert-pr-changes

Conversation

@st0012

@st0012 st0012 commented Jun 11, 2026

Copy link
Copy Markdown
Member

Problem

PR #841 made Graph#index_source accept omitted or nil language_id, but that API is intended for in-memory LSP sources where the caller must provide the language explicitly.

Changes

  • Restores Graph#index_source(uri, source, language_id) as a required three-argument API.
  • Removes Rust-side fallback language inference for rdx_index_source.
  • Removes tests that asserted omitted or nil language_id worked.

@st0012 st0012 marked this pull request as ready for review June 11, 2026 20:43
@st0012 st0012 requested a review from a team as a code owner June 11, 2026 20:43
@st0012 st0012 merged commit 7581a62 into main Jun 11, 2026
36 checks passed
@st0012 st0012 deleted the codex/revert-pr-changes branch June 11, 2026 21:12
@st0012 st0012 self-assigned this Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants