Add more tests for superclass resolution behaviour#860
Open
amomchilov wants to merge 3 commits into
Open
Conversation
This behaviour is implied by other tests, but I would like to single it out specifically.
vinistock
approved these changes
Jun 12, 2026
| ); | ||
| } | ||
|
|
||
| // Contrast with this case, which Ruby allows:: |
Member
There was a problem hiding this comment.
I think this is already encoded in the other tests, so I would remove it from this one.
Contributor
Author
There was a problem hiding this comment.
Which one? I don't see it
Member
There was a problem hiding this comment.
Is this not the same as C1 in superclass_is_load_order_independent? Also, I would split each thing into their own test rather than checking multiple things in each example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents existing behaviour as-is.
Adds some pending tests that will need to be fixed in the future for: