Open
Conversation
2500302 to
ad84acd
Compare
dfc822f to
b13d1d4
Compare
Replace @shopify/eslint-plugin + eslint + eslint-plugin-jest with Oxlint (https://oxc.rs/docs/guide/usage/linter), a Rust-based linter ~50–100x faster. Changes: - Delete eslint.config.js, add oxlint.json with equivalent rule config - Update all 20 package lint scripts from `eslint .` to `oxlint .` - Remove ESLint devDependencies (eslint, @shopify/eslint-plugin, eslint-plugin-jest) and add oxlint@^1.0.0 - Run Prettier as a standalone `prettier` script instead of via ESLint; fix .prettierignore glob patterns for remix/react-router example files - Fix 42 Oxlint violations introduced by stricter rule enforcement: - no-non-null-asserted-optional-chain in billing helpers and express config - no-unsafe-optional-chaining in request-mock.ts (remix + react-router) - no-unused-vars: rename catch params to _error/_err, remove unused imports Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
b13d1d4 to
bb93899
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ESLint (with
@shopify/eslint-plugin) has accumulated significant startup overhead and transitive dependencies. Oxlint is a Rust-based linter that is ~50–100x faster, with a much smaller dependency footprint.What
eslint.config.js, addsoxlint.jsonwith equivalent rules (TypeScript, import, and promise plugins)lintscripts fromeslint .tooxlint .eslint,@shopify/eslint-plugin,eslint-plugin-jest) and addoxlint@^1.0.0prettierscript (prettier --check .) separate from linting. The.prettierignoreglob patterns for Remix/React Router example files are also fixed (*.example.tsx?→ explicit.ts/.tsxpatterns)no-non-null-asserted-optional-chain— billing helpers and Express configno-unsafe-optional-chaining—request-mock.ts(Remix + React Router)no-unused-vars— catch params renamed to_error/_err, unused imports removedTesting
All CI checks pass (lint + tests across Node 20/22/24).