fix: add preview.admin.shopify.com to CSP frame-ancestors#3156
Draft
fix: add preview.admin.shopify.com to CSP frame-ancestors#3156
Conversation
Embedded apps set a Content-Security-Policy frame-ancestors header that controls which origins can iframe them. The current list omits https://*.preview.admin.shopify.com, causing apps to refuse loading inside admin preview environments. Add the missing origin to the CSP directive in all three framework packages (Remix, Express, React Router) and update corresponding tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://*.preview.admin.shopify.comto the CSPframe-ancestorsdirective across all three framework packages (Remix, Express, React Router)Test plan
add-response-headerstests pass (4 tests)csp-headerstests pass (7 tests)add-response-headerstests pass (1 test)*.preview.admin.shopify.comenvironment after bumping to this version🤖 Generated with Claude Code