fix: log actual shop value in 'Authenticating admin request' (fixes #2916)#3159
Open
github-actions[bot] wants to merge 1 commit intomainfrom
Open
fix: log actual shop value in 'Authenticating admin request' (fixes #2916)#3159github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
…2916) The info log was calling getShopFromRequest which reads the shop query parameter from the URL. For session-token/token-exchange auth flows, shop is not present as a query param, so it always logged null. Move the info log to after getSessionTokenContext so the shop value extracted from the JWT payload is used instead. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
infolog at the start ofauthenticateAdminwas callinggetShopFromRequest(request), which reads theshopquery parameter from the URL.shopis not a query parameter — it's embedded in the JWT. So the log always emittednull.logger.info('Authenticating admin request', ...)call to aftergetSessionTokenContextresolves, whereshophas been extracted from the JWT payload.Fixes #2916.
Root Cause
Test plan
nullin an embedded app using token-exchange auth.🤖 Generated with Claude Code