Preserve heredoc body when translating multi-line T.let assertions#943
Merged
Conversation
styrmis
force-pushed
the
06-08-fix-spoom-heredoc-handling
branch
4 times, most recently
from
3c92653 to
a5d6263
Compare
KaanOzkan
reviewed
Jun 9, 2026
styrmis
force-pushed
the
06-08-fix-spoom-heredoc-handling
branch
from
c9269d5 to
74e0e3f
Compare
KaanOzkan
reviewed
Jun 15, 2026
| when Prism::StringNode, Prism::InterpolatedStringNode | ||
| opening = node.opening_loc | ||
| closing = node.closing_loc | ||
| if opening && closing && opening.start_line != closing.start_line |
Contributor
There was a problem hiding this comment.
I guess you could split a string in multiple lines 😄
s = T.let(
"first
second",
String,
)I found slice, so we can add a opening.slice.start_with?("<<") check to the conditional:
opening && closing && opening.start_line != closing.start_line && opening.slice.start_with?("<<")
Contributor
Author
There was a problem hiding this comment.
Nice catch—have separately added coverage for backticks in heredocs.
KaanOzkan
reviewed
Jun 22, 2026
|
|
||
| assert_equal(<<~RB, rbi_to_rbs(rb)) | ||
| s = "first | ||
| second" #: String |
Contributor
There was a problem hiding this comment.
Suggested change
| second" #: String | |
| second" #: String |
I think preserving the indentation is better than not preserving it, wdyt?
Contributor
Author
There was a problem hiding this comment.
Completely agree—looks like this is existing behaviour of dedent_value but the fix is small and it doesn't affect any other tests so have applied it in 5b2aa51 👍
When `T.let(...)` spans multiple lines and wraps a heredoc, the replacement range covers the entire call including the heredoc body. Since the value node's source range only covers the opener line (e.g. `<<~MSG.strip`), the body and terminator were silently dropped, producing syntactically broken Ruby.
Before this change we would stop at the first heredoc.
styrmis
force-pushed
the
06-08-fix-spoom-heredoc-handling
branch
from
d49563b to
5b2aa51
Compare
`dedent_value` was stripping indentation from lines inside string literals, changing their content. With this change we only dedent structural indentation (arrays, hashes, etc.), not string content.
styrmis
force-pushed
the
06-08-fix-spoom-heredoc-handling
branch
from
5b2aa51 to
3c764a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
T.let(...)spans multiple lines and wraps a heredoc, the replacement range covers the entire call including the heredoc body. Since the value node's source range only covers the opener line (e.g.<<~MSG.strip), the body and terminator were silently dropped, producing syntactically broken Ruby.