Introduce Options object#954
Merged
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
amomchilov
force-pushed
the
Alex/Options-object
branch
3 times, most recently
from
d5692f6 to
7654edc
Compare
vinistock
force-pushed
the
Alex/Options-object
branch
from
7654edc to
42fbc58
Compare
vinistock
force-pushed
the
Alex/Options-object
branch
from
42fbc58 to
9d80524
Compare
KaanOzkan
reviewed
Jun 19, 2026
Co-authored-by: Vinicius Stock <vinistock@users.noreply.github.com>
vinistock
force-pushed
the
Alex/Options-object
branch
from
9d80524 to
48c4e23
Compare
KaanOzkan
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a more complex
Optionsobject to allow us to have different sets of configuration. For example, max line length does not apply to the new line preserving format (which may need to create very long lines to preserve backtraces).The idea is to have a base object that gets specialized for the different cases.