Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/vscode-extension/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,10 @@
"test": "vitest",
"pretest:web": "[ -d .tmp/dawn ] || git clone --depth 1 https://github.com/Shopify/dawn.git .tmp/dawn",
"build:test": "webpack --config webpack.test.config.js --mode development",
"build:test:debug": "DEBUG_DELAY=10000 webpack --config webpack.test.config.js --mode development",
"build:test:debug": "WATCH_MODE=1 DEBUG_DELAY=10000 webpack --config webpack.test.config.js --mode development",
"build:test:watch": "WATCH_MODE=1 webpack --config webpack.test.config.js --mode development --watch",
"test:web": "yarn build && yarn build:test && vscode-test-web --browserType=chromium --headless --extensionDevelopmentPath=. --extensionTestsPath=./dist/browser/test/suite/index.js .tmp/dawn",
"test:web:debug": "yarn build && yarn build:test:debug && vscode-test-web --browserType=chromium --extensionDevelopmentPath=. --extensionTestsPath=./dist/browser/test/suite/index.js .tmp/dawn",
"test:web:debug": "vscode-test-web --browserType=chromium --extensionDevelopmentPath=. --extensionTestsPath=./dist/browser/test/suite/index.js .tmp/dawn",
"type-check:test": "tsc --project test/tsconfig.json --noEmit",
"type-check": "tsc --noEmit"
},
Expand Down
37 changes: 37 additions & 0 deletions packages/vscode-extension/test/browser/suite/activation.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,41 @@ suite('Browser Extension Activation', () => {
`Critical errors found: ${criticalErrors.join('; ')}`,
);
});

test('Autocomplete suggests "product" for Liquid objects', async function () {
this.timeout(30000); // LSP may take time to initialize

// 1. Get workspace file URI
const wsFolder = vscode.workspace.workspaceFolders![0].uri;
const fileUri = vscode.Uri.joinPath(wsFolder, 'layout', 'theme.liquid');

// 2. Open and show document
const doc = await vscode.workspace.openTextDocument(fileUri);
const editor = await vscode.window.showTextDocument(doc);

// 3. Insert text at beginning
const position = new vscode.Position(0, 0);
await editor.edit((editBuilder) => {
editBuilder.insert(position, '{{ prod');
});

// 4. Wait for LSP to be ready (may need small delay)
await new Promise((resolve) => setTimeout(resolve, 2000));

// 5. Trigger completions at cursor (after "{{ prod")
const completions = await vscode.commands.executeCommand<vscode.CompletionList>(
'vscode.executeCompletionItemProvider',
doc.uri,
new vscode.Position(0, 7), // position after "{{ prod"
);

// 6. Assert "product" is in suggestions
const labels = completions!.items.map((item) =>
typeof item.label === 'string' ? item.label : item.label.label,
);
assert.ok(
labels.includes('product'),
`Expected "product" in completions, got: ${labels.slice(0, 10).join(', ')}`,
);
});
});
6 changes: 6 additions & 0 deletions packages/vscode-extension/test/browser/suite/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ export async function run(): Promise<void> {

try {
mocha.run((failures) => {
// In watch mode, never resolve the promise so browser stays open
if (process.env.WATCH_MODE) {
console.log('[Watch Mode] Tests complete. Browser staying open. Refresh to re-run.');
return; // Never resolve - browser stays open
}

if (failures > 0) {
reject(new Error(`${failures} tests failed.`));
} else {
Expand Down
1 change: 1 addition & 0 deletions packages/vscode-extension/webpack.test.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ const browserTestConfig = {
new webpack.DefinePlugin({
'process.env.WEBPACK_MODE': true,
'process.env.DEBUG_DELAY': JSON.stringify(process.env.DEBUG_DELAY || '0'),
'process.env.WATCH_MODE': JSON.stringify(process.env.WATCH_MODE || ''),
}),
],
devtool: 'source-map',
Expand Down