feat(point-of-sale): add paymentmethodselected intercept types - #4611
Open
aaronschubert0 wants to merge 1 commit into
Open
feat(point-of-sale): add paymentmethodselected intercept types#4611aaronschubert0 wants to merge 1 commit into
aaronschubert0 wants to merge 1 commit into
Conversation
aaronschubert0
force-pushed
the
pos-intercept-payment-method-selected
branch
from
August 11, 2026 12:44
1953c8d to
5843221
Compare
Assisted-By: devx/815595f2-0ce0-49e1-87fc-903983c87fa6
aaronschubert0
force-pushed
the
pos-intercept-payment-method-selected
branch
from
August 11, 2026 12:51
5843221 to
d5dd478
Compare
aaronschubert0
marked this pull request as ready for review
August 11, 2026 13:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Enables payment-type interception (cash first) for extensible client-side validations — e.g. compliance workflows blocking cash tenders until required data is collected. Types-only and
@private;What
Adds the second interceptable workflow to the POS surface's private intercept API:
paymentmethodselected, dispatched when staff selects a payment method on the payments screen.Follows the pattern established in #4520 (
beforecheckout):POS_INTERCEPT_NAMESentry:PAYMENT_METHOD_SELECTED: 'paymentmethodselected'ShopifyInterceptMapentry soshopify.intercept()picks up the workflow through the map generic — no changes toglobals.tsPaymentMethodSelectedEvent,InterceptedPaymentMethod,InterceptedPaymentMethodTypeInterceptResult/Operation/ValidationAddare shared unchanged:ERRORblocks the selected method,WARNINGdoes not.Payload
paymentMethod: {type, identifier?}—typeis a stable string vocabulary (the internal numericPaymentOptionTypenever crosses the boundary), constrained to'cash'for v1; further method kinds join the union as they become interceptable.identifieris reserved for method types a shop can have several of (custom / local payment methods); unused for cash. Matching is exact on the pair.amount: MoneyV2— the per-tender amount in presentment currency.Intentionally minimal for v1:
References
beforecheckout)