Remove Action API from POS cart line-item action render target - #4612
Open
aaronschubert0 wants to merge 1 commit into
Open
Remove Action API from POS cart line-item action render target#4612aaronschubert0 wants to merge 1 commit into
aaronschubert0 wants to merge 1 commit into
Conversation
pos.cart.line-item-details.action.render was the only *.action.render target whose API type included ActionApi. Action render targets are the modal destination shopify.action.presentModal() opens, so the surface was non-functional there (it pushed a duplicate modal of the same target). - extension-targets.ts: drop ActionApi from the target type (ActionTargetApi + CartApi + CartLineItemApi only) and document Navigation API usage. - ui-extensions-tester: retype the Group N factory to the target's new surface and add regression coverage asserting the Action API is not exposed on the render target (but still is on the menu-item sibling). - Regenerate targets.json + generated_docs_data_v2.json so target metadata and docs no longer advertise Action API support. - Changeset (major): versioned breaking change — removed for apiVersions 2026-07+, older pinned versions keep their published surface. Part of shop/issues-retail#33068 Assisted-By: devx/59d0a60c-7b60-4f69-bb24-197efae896ea
aaronschubert0
force-pushed
the
fix/pos-remove-action-api-from-action-render
branch
from
August 11, 2026 13:39
603da30 to
870761a
Compare
henryStelle
reviewed
Aug 12, 2026
henryStelle
left a comment
henryStelle
left a comment
Contributor
There was a problem hiding this comment.
2026-07 has already stabilized, I think you need to target 2026-10-rc
Contributor
|
@henryStelle we can usually back-fix |
js-goupil
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of shop/issues-retail#33068.
pos.cart.line-item-details.action.renderis the only*.action.rendertarget whose API type includesActionApi. Action render targets are the modal destinationshopify.action.presentModal()opens, so the surface had no meaningful destination there — it pushed a duplicate modal of the same target.Changes
extension-targets.ts— the target is nowActionTargetApi + CartApi + CartLineItemApi, matching every other action render target. JSDoc points partners at the Navigation API for in-workflow navigation.createActionTargetCartLineItemMock) + regression test asserting no Action API on the render target (pos-action-render-targets.test.ts).targets.json+generated_docs_data_v2.json(2026-07-rc); target metadata no longer advertises Action API support.major): versioned breaking change — removed for apiVersions2026-07+; older pinned versions keep their published surface. The host-side runtime gate lands in Shopify/extensibility.Validation
loom type-check+loom lintpass;ui-extensions-tester78/78 tests pass. Repo-wide failures are pre-existing checkout/preact suites (missingreact-test-rendererinstall), unrelated.