Skip to content

Adding e2e test for one off job#22

Open
Showtim3 wants to merge 4 commits intodevelopfrom
e2e-adminOneOff
Open

Adding e2e test for one off job#22
Showtim3 wants to merge 4 commits intodevelopfrom
e2e-adminOneOff

Conversation

@Showtim3
Copy link
Copy Markdown
Owner

Explanation

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python -m scripts.pre_commit_linter and python -m scripts.run_frontend_tests.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

@codecov-io
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (develop@d633c0d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #22   +/-   ##
==========================================
  Coverage           ?   47.74%           
==========================================
  Files              ?      851           
  Lines              ?    35001           
  Branches           ?     4119           
==========================================
  Hits               ?    16710           
  Misses             ?    17444           
  Partials           ?      847
Flag Coverage Δ
#frontend 47.74% <ø> (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants