Please consider the following formatting changes to #17006 - #10
Closed
alibuild wants to merge 4 commits into
Closed
Conversation
- New ReducedEMCals table: standalone skimmed EMCal cluster table (unique clusters only for now; isAmbiguous flag reserved for the ambiguous clusters treatment) - New ReducedTracksBarrelEMCal table: joinable to ReducedTracks, one entry per skimmed track with the index of the best matched (smallest delta-R) skimmed cluster (-1 if none) and the matching residuals - VarManager: TrackEMCal object type, kEMCal* variables incl. E/p and matching residuals, FillTrackEMCal() usable both with EMCALClusters and ReducedEMCals rows - HistogramsLibrary: emcal and emcalmatch histogram subgroups - tableMaker_withAssoc: skimEMCal() (Preslice-based, runs before the track skimming so matching indices are available), JSON cluster cuts, QA and stats, new processPPBarrelOnlyWithEMCal process function (requires the emcal-correction-task upstream in the workflow) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PMjqae9gYxRGYHfychqECY
…eReader_withAssoc - AnalysisTrackSelection: new processSkimmedWithEMCal and processSkimmedWithCovWithEMCal process functions, subscribing to the ReducedTracksBarrelEMCal (joined to the barrel tracks) and ReducedEMCals tables; the matched cluster quantities (incl. E/p and the matching residuals) are filled in the VarManager so they can be used in the track cuts (e.g. JSON cuts on kEMCalEoverP) and QA histograms - tableMaker_withAssoc: new processPPWithEMCal process function producing the full (barrel + muon) DQ skimmed data model with EMCal clusters, e.g. for e-mu correlations with EMCal electron ID Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PMjqae9gYxRGYHfychqECY
|
O2 linter results: ❌ 128 errors, |
Shunsuke-Kurita
force-pushed
the
dq-emcal-skimming
branch
from
July 12, 2026 08:36
b5b44df to
73a5c20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your PR AliceO2Group#17006 cannot be merged as is. You should either run
clang-formatyourself and update the pull request, or merge this PR in yours.You can find the AliceO2 coding conventions at https://github.com/AliceO2Group/CodingGuidelines.