Skip to content

Please consider the following formatting changes to #15490 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alibuild wants to merge 1 commit into from
Closed

Please consider the following formatting changes to #15490 #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions PWGDQ/Tasks/tableReader_withAssoc_direct.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@
TString eventCutJSONStr = fConfigEventCutsJSON.value;
if (eventCutJSONStr != "") {
std::vector<AnalysisCut*> jsonCuts = dqcuts::GetCutsFromJSON(eventCutJSONStr.Data());
for (auto& cutIt : jsonCuts) {

Check failure on line 349 in PWGDQ/Tasks/tableReader_withAssoc_direct.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
fEventCut->AddCut(cutIt);
}
}
Expand Down Expand Up @@ -406,7 +406,6 @@
if (fConfigRCT.fConfigUseRCT.value) {
rctChecker.init(fConfigRCT.fConfigRCTLabel, fConfigRCT.fCheckZDC.value);
}

}

template <uint32_t TEventFillMap, typename TEvents>
Expand Down Expand Up @@ -474,7 +473,7 @@
fSelMap.clear();
fBCCollMap.clear();

for (auto& event : events) {

Check failure on line 476 in PWGDQ/Tasks/tableReader_withAssoc_direct.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
auto bc = event.template bc_as<BCsWithTimestamps>();

VarManager::ResetValues(VarManager::kNTFWiseVariables, VarManager::kNEventWiseVariables);
Expand Down Expand Up @@ -525,7 +524,6 @@
hash(hh);
}
}

}

// Variant of runEventSelection that first checks the DqFilters EMu prefilter bit.
Expand Down Expand Up @@ -593,7 +591,7 @@
fSelMap.clear();
fBCCollMap.clear();

for (auto& event : events) {

Check failure on line 594 in PWGDQ/Tasks/tableReader_withAssoc_direct.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
// Skip events that did not pass any filterPP selection.
// The bit position depends on filterPP config (fNBarrelCuts + fNMuonCuts + emu_index),
// so check eventFilter != 0 rather than a hardcoded bit.
Expand Down Expand Up @@ -651,7 +649,6 @@
hash(hh);
}
}

}

template <uint32_t TEventFillMap, typename TEvents>
Expand Down Expand Up @@ -695,10 +692,10 @@
auto const& bc2Events = bc2It->second;

// loop over events in the first BC
for (auto ev1It : bc1Events) {

Check failure on line 695 in PWGDQ/Tasks/tableReader_withAssoc_direct.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
auto ev1 = events.rawIteratorAt(ev1It);
// loop over events in the second BC
for (auto ev2It : bc2Events) {

Check failure on line 698 in PWGDQ/Tasks/tableReader_withAssoc_direct.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
auto ev2 = events.rawIteratorAt(ev2It);
// compute 2-event quantities and mark the candidate split collisions
VarManager::FillTwoEvents(ev1, ev2);
Expand All @@ -716,7 +713,7 @@

// publish the table
uint32_t evSel = static_cast<uint32_t>(0);
for (auto& event : events) {

Check failure on line 716 in PWGDQ/Tasks/tableReader_withAssoc_direct.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
evSel = 0;
if (fSelMap[event.globalIndex()]) { // event passed the user cuts
evSel |= (static_cast<uint32_t>(1) << 0);
Expand Down Expand Up @@ -803,7 +800,7 @@
TString addTrackCutsStr = fConfigCutsJSON.value;
if (addTrackCutsStr != "") {
std::vector<AnalysisCut*> addTrackCuts = dqcuts::GetCutsFromJSON(addTrackCutsStr.Data());
for (auto& t : addTrackCuts) {

Check failure on line 803 in PWGDQ/Tasks/tableReader_withAssoc_direct.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
fTrackCuts.push_back(reinterpret_cast<AnalysisCompositeCut*>(t));
}
}
Expand All @@ -818,7 +815,7 @@

// Configure histogram classes for each track cut;
TString histClasses = "TimeFrameStats;AssocsBarrel_BeforeCuts;";
for (auto& cut : fTrackCuts) {

Check failure on line 818 in PWGDQ/Tasks/tableReader_withAssoc_direct.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
TString nameStr = Form("AssocsBarrel_%s", cut->GetName());
fHistNamesReco.push_back(nameStr);
histClasses += Form("%s;", nameStr.Data());
Expand All @@ -839,7 +836,6 @@
fCCDB->setLocalObjectValidityChecking();
fCCDB->setCreatedNotAfter(fConfigNoLaterThan.value);
fTofResponse->initSetup(fCCDB, context);

}

template <uint32_t TEventFillMap, uint32_t TTrackFillMap, typename TEvents, typename TTracks>
Expand Down Expand Up @@ -880,8 +876,7 @@
trackSel.reserve(assocs.size());
trackAmbiguities.reserve(tracks.size());


for (auto& assoc : assocs) {

Check failure on line 879 in PWGDQ/Tasks/tableReader_withAssoc_direct.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
auto event = assoc.template collision_as<TEvents>();
if (!event.isEventSelected_bit(0)) {
trackSel(0);
Expand Down Expand Up @@ -948,7 +943,7 @@
// So one could QA these tracks separately
if (fConfigPublishAmbiguity) {
if (fConfigQA) {
for (auto& [trackIdx, evIndices] : fNAssocsInBunch) {

Check failure on line 946 in PWGDQ/Tasks/tableReader_withAssoc_direct.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
if (evIndices.size() == 1) {
continue;
}
Expand Down Expand Up @@ -984,7 +979,6 @@
trackAmbiguities(nInBunch, nOutOfBunch);
}
}

}

void processWithCov(TrackAssoc const& assocs, BCsWithTimestamps const& bcs, MyEventsSelected const& events, MyBarrelTracksWithCov const& tracks)
Expand Down Expand Up @@ -1674,7 +1668,6 @@
dqhistograms::AddHistogramsFromJSON(fHistMan, fConfigOptions.fConfigAddJSONHistograms.value.c_str()); // ad-hoc histograms via JSON
VarManager::SetUseVars(fHistMan->GetUsedVars()); // provide the list of required variables so that VarManager knows what to fill
fOutputList.setObject(fHistMan->GetMainHistogramList());

}

void initParamsFromCCDB(uint64_t timestamp, bool withTwoProngFitter = true)
Expand Down Expand Up @@ -1950,7 +1943,6 @@
} // end loop (cuts)
} // end loop over pairs of track associations
} // end loop over events

}

// Template function for electron-muon same-event pairing (barrel x muon, full index policy)
Expand Down
Loading