Skip to content

Add additional context when siacoin input validation fails#387

Open
ChrisSchinnerl wants to merge 3 commits intomasterfrom
chris/validate-context
Open

Add additional context when siacoin input validation fails#387
ChrisSchinnerl wants to merge 3 commits intomasterfrom
chris/validate-context

Conversation

@ChrisSchinnerl
Copy link
Member

No description provided.

@ChrisSchinnerl ChrisSchinnerl self-assigned this Mar 6, 2026
Copilot AI review requested due to automatic review settings March 6, 2026 14:55
@github-project-automation github-project-automation bot moved this to In Progress in Sia Mar 6, 2026
Copy link
Member

@n8mgr n8mgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string error messages strike again

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves debugging of v2 siacoin input spend-policy validation failures by adding more detail to the returned error messages, and documents the change via a knope changeset.

Changes:

  • Add satisfied/required counts to the PolicyTypeThreshold “threshold not reached” verification error.
  • Expand the v2 siacoin spend-policy validation error to include parent output ID and other transaction context.
  • Add a .changeset entry describing the change.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
types/policy.go Enriches the threshold-policy verification failure message with satisfied/required counts.
consensus/validation.go Adds extra context to the siacoin input spend-policy failure error message.
.changeset/additional_context_in_error_message_when_the_signing_threshold_of_a_spend_policy_wasnt_reached.md Documents the change for release notes via knope changesets.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 50eac7466a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ChrisSchinnerl ChrisSchinnerl force-pushed the chris/validate-context branch from 50eac74 to a1a6985 Compare March 6, 2026 15:00
@ChrisSchinnerl ChrisSchinnerl force-pushed the chris/validate-context branch 2 times, most recently from 8614e56 to b4fa577 Compare March 6, 2026 15:35
@ChrisSchinnerl ChrisSchinnerl force-pushed the chris/validate-context branch from b4fa577 to 7a62510 Compare March 6, 2026 15:37
@ChrisSchinnerl ChrisSchinnerl requested a review from n8mgr March 6, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

4 participants