Add additional context when siacoin input validation fails#387
Add additional context when siacoin input validation fails#387ChrisSchinnerl wants to merge 3 commits intomasterfrom
Conversation
n8mgr
left a comment
There was a problem hiding this comment.
string error messages strike again
There was a problem hiding this comment.
Pull request overview
This PR improves debugging of v2 siacoin input spend-policy validation failures by adding more detail to the returned error messages, and documents the change via a knope changeset.
Changes:
- Add satisfied/required counts to the
PolicyTypeThreshold“threshold not reached” verification error. - Expand the v2 siacoin spend-policy validation error to include parent output ID and other transaction context.
- Add a
.changesetentry describing the change.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
types/policy.go |
Enriches the threshold-policy verification failure message with satisfied/required counts. |
consensus/validation.go |
Adds extra context to the siacoin input spend-policy failure error message. |
.changeset/additional_context_in_error_message_when_the_signing_threshold_of_a_spend_policy_wasnt_reached.md |
Documents the change for release notes via knope changesets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
...ional_context_in_error_message_when_the_signing_threshold_of_a_spend_policy_wasnt_reached.md
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50eac7466a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
50eac74 to
a1a6985
Compare
8614e56 to
b4fa577
Compare
b4fa577 to
7a62510
Compare
No description provided.