Optimize events#79
Merged
Merged
Conversation
|
…alid search options - Updated FFI functions in `phase.rs`, `runtime_ephemeris.rs`, `subject.rs`, `target.rs`, and `twilight.rs` to replace TODO comments with SAFETY documentation, clarifying raw-pointer usage and C ABI preconditions. - Enhanced `SiderustSearchOpts` to validate `time_tolerance_days` for non-finite and non-positive values, rejecting invalid options. - Added tests to ensure invalid search options are correctly handled in event queries. - Removed unused event functions from `AltitudeProvider` trait implementations in `provider.rs`. - Improved fallback mechanisms in `moon_cache.rs` and `search.rs` to handle cases outside cache ranges. - Updated documentation to reflect changes in default time tolerance values across various modules. - Added tests for new functionality ensuring robustness in altitude and crossing event queries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.