Skip to content
This repository was archived by the owner on Mar 12, 2026. It is now read-only.

Accessibility fixes#28

Open
miguelbcr wants to merge 2 commits intomainfrom
mg/accessibility-fixes
Open

Accessibility fixes#28
miguelbcr wants to merge 2 commits intomainfrom
mg/accessibility-fixes

Conversation

@miguelbcr
Copy link
Copy Markdown
Contributor

@miguelbcr miguelbcr commented Jul 31, 2023

Ticket

This PR fixes the issues detected by the Accessibility Scanner App and I have also run the TalkBack App to check how it is talked.

ℹ️ I've created the files accessibility-strings.xml, in both, showcase module and for the SDK itself (core.ui module). Currently I've added only english translations (@chemarubio @VictorAlbertos could you please review the copy), but we would need also translations for the languages we support, currently en and de.

Usage example of Accessibility Scanner App

1 2
Screenshot 2023-07-28 at 12 17 23 Screenshot 2023-07-28 at 12 17 31

Video example

accesibility-scanner.mp4

@miguelbcr miguelbcr self-assigned this Jul 31, 2023
@miguelbcr miguelbcr requested review from VictorAlbertos and chemarubio and removed request for chemarubio July 31, 2023 14:12
@@ -0,0 +1,13 @@
<resources>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need a German translation for the talk back to handle this

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all these copies needs to be verified by translators, let's see how we can make accessibility copies part of the translation process 👍

it
}
}
contentDescription = null
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know @miguelbcr if google has some kind "on the fly" ML models to "read" the content of dynamic images (not only UI resources)?

Copy link
Copy Markdown
Contributor Author

@miguelbcr miguelbcr Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially filled that contentDescription with the title of the card, detail page,... but I removed it eventually because I though it was not needed to repeat the same content description when using TalkBack.

Looking at the doc it says:
Screenshot 2023-08-01 at 09 18 56

so I think for our case is not needed because the image always goes with a text...

The ways of testing or analyzing it are the ones described here https://developer.android.com/guide/topics/ui/accessibility/testing. I used the two first ones (TalkBack and Accessibility Scanner)

Also in some cases I use .semantics(mergeDescendants = true) {} to let some widgets to use the same text in one child within the parent, for example a card containing image and text.

Screenshot 2023-08-01 at 09 33 32

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks for the clarification!

Copy link
Copy Markdown
Contributor

@VictorAlbertos VictorAlbertos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Miguel 🚀

Copy link
Copy Markdown
Contributor

@chemarubio chemarubio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 great ! Maybe some linter issues need to be addressed before merging.

@miguelbcr miguelbcr force-pushed the mg/accessibility-fixes branch from 16eccc7 to 07594bd Compare August 14, 2023 08:32
@miguelbcr miguelbcr force-pushed the mg/accessibility-fixes branch from 07594bd to aeda125 Compare September 7, 2023 07:59
@miguelbcr miguelbcr force-pushed the mg/accessibility-fixes branch from aeda125 to 0bff07e Compare September 7, 2023 08:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants