Add read-only buffer support and smart streaming for Docker logs#252
Merged
Silex merged 2 commits intoSilex:mainfrom Jan 26, 2026
Merged
Add read-only buffer support and smart streaming for Docker logs#252Silex merged 2 commits intoSilex:mainfrom
Silex merged 2 commits intoSilex:mainfrom
Conversation
Owner
|
What a beautiful PR 👍 Thanks. |
Contributor
Author
|
🎉 |
Owner
|
For the record I refactored your changes into explicit interactive/non-interactive in 9cb4349 |
Contributor
Author
|
Makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
When viewing the logs of a container that had very long outputs (in non-follow mode), it would take 30s for the logs to fully populate the buffer. That in comparison with running it in my cli which takes 0.2 seconds. So I decided to dig in and fix this issue.
Solution
Changes
docker-process.el:
docker-core.el:
docker-container.el: