C++20 compatibility#28
Open
affeltranger wants to merge 4 commits into
Open
Conversation
added 2 commits
October 22, 2025 08:36
- ++ operator on volatile variable is deprecated
- use __NOP() statement which includes volatile instead of __ASM("NOP")
…, remove volatile statement from affected loop iterators
added 2 commits
October 22, 2025 09:15
…, remove volatile statement from affected loop iterators
- returns client_socket_id instead of SL_STATUS_OK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces __ASM("NOP") with __NOP() and removes the volatile statement from surrounding loops.
C++ 20 deprecates the ++ operator in volatile variables, which is fine for the .c files, but not for header files included in .cpp.
The volatile statement in __NOP() ensures that the loop will not get optimized away when using a regular iterator instead of a volatile one.