[Bytesafe] Add support for serviceAccountName#44
Open
conclusionlogic wants to merge 1 commit intoSimCubeLtd:masterfrom
Open
[Bytesafe] Add support for serviceAccountName#44conclusionlogic wants to merge 1 commit intoSimCubeLtd:masterfrom
conclusionlogic wants to merge 1 commit intoSimCubeLtd:masterfrom
Conversation
This commit introduces several changes to the `statefulSet.yaml` template to enhance readability and maintainability: - Indentation has been corrected across various sections to ensure consistency and improve the visual hierarchy of the YAML structure. - Conditional blocks for `statefulSet.labels`, `statefulSet.annotations`, `pod.labels`, and `pod.annotations` have been adjusted to include proper indentation and spacing, making it easier to distinguish between nested properties. - The `serviceName` attribute under `spec` has been explicitly set to use the `bytesafe.fullname` template, ensuring clarity in service references. - Added conditions to check the creation of a ServiceAccount and set `automountServiceAccountToken` to true as well as referenced the correct ServiceAccount name.
conclusionlogic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a few updates to the
statefulSet.yamltemplate:automountServiceAccountTokento true as well as referenced the correct ServiceAccountName value.serviceNameattribute underspechas been explicitly set to use thebytesafe.fullnametemplate, ensuring clarity in service references.statefulSet.labels,statefulSet.annotations,pod.labels, andpod.annotationshave been adjusted to include proper indentation and spacing, making it easier to distinguish between nested properties.