add java.time.LocalDate support to Row#72
Open
wonk1132 wants to merge 1 commit intoSimpleFinance:masterfrom
Open
add java.time.LocalDate support to Row#72wonk1132 wants to merge 1 commit intoSimpleFinance:masterfrom
wonk1132 wants to merge 1 commit intoSimpleFinance:masterfrom
Conversation
vanvlack
requested changes
Sep 18, 2019
Member
vanvlack
left a comment
vanvlack
left a comment
There was a problem hiding this comment.
Looks like this is against master, which is scala 2.12.x, if you could backport to the 2.11 branch as well, that would be great.
| /** | ||
| * Extract the value with the given name as an Option[LocalDate]. | ||
| */ | ||
| def localDate(name: String): Option[LocalDate] = extract(rs.getDate(name).toLocalDate) |
Member
There was a problem hiding this comment.
you could do:
localDateTime(name).map(_.toLocalDate)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as the name suggests, since we are using
java.time.LocalDate, we should have jdub help us out.