Add support for allowance_change, various bug fixes for debug messages

config/internal_config_alerts.ini

@@ -68,6 +68,7 @@ EscrowAddEventSelfOwner=true
 EscrowAddEventSelfEscrow=true
 EscrowReclaimEventSelfOwner=true
 EscrowReclaimEventSelfEscrow=true
+AllowanceChangeAlert=true
 UnknownEventFound=true
 
 [finalized_block_height_alerts_enabled_disabled]

src/alerters/reactive/node.py

@@ -290,7 +290,7 @@ def load_state(self, logger: logging.Logger) -> None:
                 '_debonding_balance=%s, _shares_balance=%s, _is_syncing=%s, '
                 '_no_of_peers=%s, _active=%s, _no_of_blocks_missed=%s, '
                 '_time_of_last_height_change=%s, '
-                '_time_of_last_height_check_activity, '
+                '_time_of_last_height_check_activity=%s, '
                 '_finalized_block_height=%s, '
                 '_no_change_in_height_warning_sent=%s, '
                 '_is_missing_blocks=%s ',
@@ -312,7 +312,7 @@ def save_state(self, logger: logging.Logger) -> None:
                 '_debonding_balance=%s, _shares_balance=%s, _is_syncing=%s, '
                 '_no_of_peers=%s, _active=%s, _no_of_blocks_missed=%s, '
                 '_time_of_last_height_change=%s, '
-                '_time_of_last_height_check_activity, '
+                '_time_of_last_height_check_activity=%s, '
                 '_finalized_block_height=%s, '
                 '_no_change_in_height_warning_sent=%s, '
                 '_is_missing_blocks=%s',
@@ -844,8 +844,25 @@ def process_event(self, event_height: str, event: dict,
                     tokens,
                     event_height,
                     source))
+
+        elif self._check_dict_path(event, 'allowance_change'):
+            if event['allowance_change']['owner'] == self.entity_public_key:
+                beneficiary = event['allowance_change']['beneficiary']
+                new_allowance = event['allowance_change']['allowance']
+                amount_change = event['allowance_change']['amount_change']
+                reduced = event['allowance_change']['negative']
+
+                logger.info('%s Node %s allowance_change %s tokens at height %s.  New allowance %s, reduced: %s, beneficiary: %s', 
+                              self, self.name, amount_change, event_height, new_allowance, reduced, beneficiary)
+                channels.alert_critical(AllowanceChangeAlert(
+                    self.name,
+                    amount_change,
+                    reduced,
+                    beneficiary,
+                    new_allowance,
+                    event_height))
         else:
-            logger.debug('%s Node received unknown event : %s', self, self.name,
+            logger.debug('%s Node %s received unknown event : %s', self, self.name,
                          event)
             channels.alert_warning(UnknownEventFound(
                 self.name,

src/alerts/alerts.py

@@ -71,6 +71,7 @@ class AlertCode(Enum):
     EscrowAddEventSelfEscrow = _next_id(),
     EscrowReclaimEventSelfOwner = _next_id(),
     EscrowReclaimEventSelfEscrow = _next_id(),
+    AllowanceChangeAlert = _next_id(),
     UnknownEventFound = _next_id(),
     DebondingBalanceIncreasedAlert = _next_id(),
     DebondingBalanceDecreasedAlert = _next_id(),
@@ -700,6 +701,14 @@ def __init__(self, node: str, old_balance: float, new_balance: float) \
             '{} total shares balance DECREASED by {} from {} to {}.'.format(
                 node, change, old_balance, new_balance))
 
+class AllowanceChangeAlert(Alert):
+
+    def __init__(self, node: str, amount_change: float, reduced: bool, beneficiary: str, new_allowance: str, height: int) \
+            -> None:        
+        super().__init__(
+            AlertCode.AllowanceChangeAlert,
+            '{} allowance changed by {}.  Reduction: {}. New allowance: {}. Beneficiary: {}. Height: {}'.format(
+                node, amount_change, reduced, new_allowance, beneficiary, height))
 
 class NewProcessCPUSecondsTotalAlert(Alert):
 

src/monitors/node.py

@@ -143,7 +143,7 @@ def save_state(self) -> None:
             key_alive = Keys.get_node_monitor_alive(self.monitor_name)
 
             self.logger.debug(
-                'Saving node monitor state: %s=%s', self._monitor_name,
+                'Saving node monitor state: %s=%s, _last_height_checked=%s', self._monitor_name,
                 key_lh, self._last_height_checked)
 
             # Set last height checked key

src/monitors/system.py

@@ -84,7 +84,7 @@ def monitor(self) -> None:
 
             process_memory_usage = float("{:.2f}".format(process_memory_usage))
 
-            self._logger.debug('%s process_memory_usage: %s%', self.system,
+            self._logger.debug('%s process_memory_usage: %s', self.system,
                                process_memory_usage)
 
             self.system.set_process_memory_usage(process_memory_usage, \
@@ -111,7 +111,7 @@ def monitor(self) -> None:
             open_file_descriptors = float("{:.2f}".format( \
                 open_file_descriptors))
 
-            self._logger.debug('%s open_file_descriptors: %s%', self.system,
+            self._logger.debug('%s open_file_descriptors: %s', self.system,
                                open_file_descriptors)
 
             self.system.set_open_file_descriptors(open_file_descriptors, \
@@ -134,7 +134,7 @@ def monitor(self) -> None:
 
             system_cpu_usage = float("{:.2f}".format(system_cpu_usage))
 
-            self._logger.debug('%s system_cpu_usage: %s%', self.system,
+            self._logger.debug('%s system_cpu_usage: %s', self.system,
                                system_cpu_usage)
 
             self.system.set_system_cpu_usage(system_cpu_usage, \
@@ -151,7 +151,7 @@ def monitor(self) -> None:
 
             system_ram_usage = float("{:.2f}".format(system_ram_usage))
 
-            self._logger.debug('%s system_ram_usage: %s%', self.system,
+            self._logger.debug('%s system_ram_usage: %s', self.system,
                                system_ram_usage)
 
             self.system.set_system_ram_usage(system_ram_usage, \
@@ -178,7 +178,7 @@ def monitor(self) -> None:
 
             system_storage_usage = float("{:.2f}".format(system_storage_usage))
 
-            self._logger.debug('%s system_storage_usage: %s%', self.system,
+            self._logger.debug('%s system_storage_usage: %s', self.system,
                                system_storage_usage)
 
             self.system.set_system_storage_usage(system_storage_usage, \

src/web/ui/src/utils/constants.js

@@ -71,6 +71,7 @@ const ALERTS_CONFIG_ALERT_NAMES = {
   EscrowAddEventSelfEscrow: 'Escrow add event when self is escrow',
   EscrowReclaimEventSelfOwner: 'Escrow reclaim event when self is owner',
   EscrowReclaimEventSelfEscrow: 'Escrow reclaim event when self is escrow',
+  AllowanceChangeAlert: 'Change of token allowance given to paratime',
   UnknownEventFound: 'Unknown event has been found',
   NodeFinalizedBlockHeightDidNotChangeInAlert: 'Finalized height not updating',
   NodeFinalizedBlockHeightHasNowBeenUpdatedAlert: 'Finalized height updated',

test/test_internal_config_alerts.ini

@@ -68,6 +68,7 @@ EscrowAddEventSelfOwner=true
 EscrowAddEventSelfEscrow=true
 EscrowReclaimEventSelfOwner=true
 EscrowReclaimEventSelfEscrow=true
+AllowanceChangeAlert=true
 UnknownEventFound=true
 
 [finalized_block_height_alerts_enabled_disabled]

test/test_internal_config_alerts_all_enabled.ini

@@ -68,6 +68,7 @@ EscrowAddEventSelfOwner=true
 EscrowAddEventSelfEscrow=true
 EscrowReclaimEventSelfOwner=true
 EscrowReclaimEventSelfEscrow=true
+AllowanceChangeAlert=true
 UnknownEventFound=true
 
 [finalized_block_height_alerts_enabled_disabled]

test/test_internal_config_alerts_some_disabled.ini

@@ -68,6 +68,7 @@ EscrowAddEventSelfOwner=true
 EscrowAddEventSelfEscrow=true
 EscrowReclaimEventSelfOwner=true
 EscrowReclaimEventSelfEscrow=true
+AllowanceChangeAlert=true
 UnknownEventFound=true
 
 [finalized_block_height_alerts_enabled_disabled]