Skip to content

[SP-5119] do not try to ack a message on a exchange #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergio-u-simspace merged 3 commits into from
Mar 12, 2026
Merged

[SP-5119] do not try to ack a message on a exchange #1

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7dbe193
do not try to ack a message on a exchange
sergio-u-simspace Mar 12, 2026
93d911c
fix formatting errors
sergio-u-simspace Mar 12, 2026
8f528f8
fixed comment
sergio-u-simspace Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions amqp/src/main/java/com/netflix/conductor/contribs/queue/amqp/AMQPObservableQueue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,12 +189,17 @@ public Address[] getAddresses() {

public List<String> ack(List<Message> messages) {
final List<String> failedMessages = new ArrayList<>();
for (final Message message : messages) {
try {
ackMsg(message);
} catch (final Exception e) {
LOGGER.error("Cannot ACK message with delivery tag {}", message.getReceipt(), e);
failedMessages.add(message.getReceipt());
if (!useExchange) {
// only attempt to ack messages when using queues.
// it makes no sense to ack over exchange since the messages are no longer there.
for (final Message message : messages) {
try {
ackMsg(message);
} catch (final Exception e) {
LOGGER.error(
"Cannot ACK message with delivery tag {}", message.getReceipt(), e);
failedMessages.add(message.getReceipt());
}
}
}
return failedMessages;
Expand Down
Loading