fix(api): wire missing Mount() calls for admin + rest endpoints - #494
Merged
Conversation
Many handler packages under apps/api/internal/admin/ and apps/api/internal/rest/ exposed a Mount()/Routes() helper but were never invoked from buildRouter — the admin UI 404'd on every one of those endpoints (users, plugin-pages, marketplace, menus, jobs DLQ, webhooks, status, impersonation, passkeys, public media/terms/users, and the global comments view). Each Mount call is nil-tolerant: when the underlying dependencies aren't available (pool nil, asynq inspector unavailable, session manager unset) the block logs a warning and skips the mount — same posture as the surrounding wiring blocks. Also fixes a syntax error in packages/go/plugins/manifest/manifest.go that prevented the api from compiling: the Flags struct was missing its closing brace after a recent merge. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: Tayeb Mokni <tayeb.mokni@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Mount calls for users, plugins, marketplace, menus, jobs, webhooks, status, impersonate, pluginpages, webauthn, public REST (users/comments/media/terms), settings, customfields. Each is nil-tolerant (logs warn + skips when deps unavailable).