🧹 Consolidate duplicate neo_verification definitions in notebook#8
Merged
Sir-Ripley merged 1 commit intogaq2from Mar 17, 2026
Merged
Conversation
…s.ipynb Consolidated 'neo_verification', 'cehtr_resolver', and 'aa_resolver' functions into a single cell (cell 13) to improve maintainability and resolve code health issues. The new definitions support both direct printing for standalone execution and returning report strings for the Visualization & Reporting Engine (VRE). Redundant definitions and imports have been removed from later cells, and shared resources like 'output_portal' are now handled consistently.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
✅ Deploy Preview for gaqv3 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideConsolidates the ODICE ODICE module helper functions and visualization output handling in QAG_VerifiedNexus.ipynb into a single shared definition cell, and wires them to support both interactive printing and string-returning behavior while removing now-redundant duplicate definitions later in the notebook. Sequence diagram for consolidated neo_verification flowsequenceDiagram
actor User
participant NotebookKernel
participant ODICEModule
participant NASA_API
User->>NotebookKernel: run neo_verification()
NotebookKernel->>ODICEModule: neo_verification()
ODICEModule->>ODICEModule: build today_date
ODICEModule->>NASA_API: GET /neo/rest/v1/feed?start_date=today&end_date=today&api_key=DEMO_KEY
NASA_API-->>ODICEModule: JSON near_earth_objects
ODICEModule->>ODICEModule: compute shielding and qag_speed for first 3 asteroids
ODICEModule->>ODICEModule: append lines to report_lines
ODICEModule->>ODICEModule: join report_lines into report_str
ODICEModule->>NotebookKernel: print(report_str)
ODICEModule-->>NotebookKernel: return report_str
NotebookKernel-->>User: display printed report_str
Sequence diagram for consolidated cehtr_resolver visualization and reportingsequenceDiagram
actor User
participant NotebookKernel
participant ODICEModule
participant Matplotlib
participant OutputPortalWidget as output_portal
User->>NotebookKernel: run cehtr_resolver(plot_results, save_only)
NotebookKernel->>ODICEModule: cehtr_resolver(plot_results, save_only)
ODICEModule->>ODICEModule: init report_lines
alt save_only is false
ODICEModule->>NotebookKernel: print header line
end
ODICEModule->>ODICEModule: define standard_friedmann, qag_friedmann
ODICEModule->>ODICEModule: solve_ivp for sol_std, sol_qag
alt plot_results or save_only
ODICEModule->>Matplotlib: create figure and axes
ODICEModule->>Matplotlib: plot sol_std and sol_qag
alt save_only is true
Matplotlib->>ODICEModule: fig
ODICEModule->>Matplotlib: fig.savefig('QAG_CEHTR_Expansion.png')
ODICEModule->>NotebookKernel: print save confirmation
else save_only is false
alt output_portal exists
ODICEModule->>OutputPortalWidget: with output_portal
OutputPortalWidget->>Matplotlib: plt.show()
else output_portal missing
ODICEModule->>Matplotlib: plt.show()
end
end
end
ODICEModule->>ODICEModule: append resolution message to report_lines
alt save_only is false
ODICEModule->>NotebookKernel: print resolution message
end
ODICEModule-->>NotebookKernel: return joined report_lines
NotebookKernel-->>User: show prints and/or saved file
Sequence diagram for consolidated aa_resolver visualization with shared output_portalsequenceDiagram
actor User
participant NotebookKernel
participant ODICEModule
participant Matplotlib
participant OutputPortalWidget as output_portal
User->>NotebookKernel: run aa_resolver(plot_results)
NotebookKernel->>ODICEModule: aa_resolver(plot_results)
ODICEModule->>NotebookKernel: print header line
ODICEModule->>ODICEModule: init report_lines
ODICEModule->>ODICEModule: create meshgrid X, Y
ODICEModule->>ODICEModule: define qag_lens
ODICEModule->>ODICEModule: compute gas and qag_affinity_peaks
alt plot_results is true
ODICEModule->>Matplotlib: create figure and axes
ODICEModule->>Matplotlib: contourf gas, contour qag_affinity_peaks
ODICEModule->>Matplotlib: plot markers, labels, title
alt output_portal exists
ODICEModule->>output_portal: with output_portal
output_portal->>Matplotlib: plt.show()
else output_portal missing
ODICEModule->>Matplotlib: plt.show()
end
end
ODICEModule->>NotebookKernel: print resolution message
ODICEModule-->>NotebookKernel: return joined report_lines
NotebookKernel-->>User: show printed text and visualization
Updated class diagram for consolidated ODICE notebook helpers and shared output_portalclassDiagram
class ODICEModule {
+output_portal Output
+neo_verification() str
+cehtr_resolver(plot_results bool, save_only bool) str
+aa_resolver(plot_results bool) str
}
class neo_verification_function {
-NASA_API_URL str
-API_KEY str
-today str
-report_lines list~str~
+neo_verification() str
}
class cehtr_resolver_function {
-Omega_m float
-Omega_L float
-affinity_base float
-t_span tuple
-t_eval ndarray
-initial_conditions list~float~
-report_lines list~str~
+standard_friedmann(t float, y list~float~) list~float~
+qag_friedmann(t float, y list~float~) list~float~
+cehtr_resolver(plot_results bool, save_only bool) str
}
class aa_resolver_function {
-X ndarray
-Y ndarray
-gas ndarray
-qag_affinity_peaks ndarray
-report_lines list~str~
+qag_lens(xc float, yc float, spread float, alpha float, m float) ndarray
+aa_resolver(plot_results bool) str
}
class OutputPortalManager {
+output_portal Output
+ensure_output_portal() Output
+show_with_portal() void
}
class Output {
+context_manager
}
ODICEModule ..> neo_verification_function : uses
ODICEModule ..> cehtr_resolver_function : uses
ODICEModule ..> aa_resolver_function : uses
ODICEModule ..> OutputPortalManager : uses
OutputPortalManager *-- Output : manages
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider adding a flag (e.g.,
verbose/print_output) toneo_verification,cehtr_resolver, andaa_resolverso callers that only need the returned string can suppress printing to stdout, which is useful in non-interactive or batch contexts. - For
standard_friedmannandqag_friedmann, using multi-line function bodies instead of one-linedef ...: return ...definitions would improve readability in this already dense setup cell. - Since
output_portalis now created conditionally in a global scope, you may want a small helper (e.g.,def get_output_portal()) to encapsulate theglobals()check and make its usage more explicit and consistent across the notebook.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a flag (e.g., `verbose` / `print_output`) to `neo_verification`, `cehtr_resolver`, and `aa_resolver` so callers that only need the returned string can suppress printing to stdout, which is useful in non-interactive or batch contexts.
- For `standard_friedmann` and `qag_friedmann`, using multi-line function bodies instead of one-line `def ...: return ...` definitions would improve readability in this already dense setup cell.
- Since `output_portal` is now created conditionally in a global scope, you may want a small helper (e.g., `def get_output_portal()`) to encapsulate the `globals()` check and make its usage more explicit and consistent across the notebook.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sir-Ripley
deleted the
fix-consolidate-neo-verification-1001432498825415985
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses a code health issue in the
QAG_VerifiedNexus.ipynbnotebook where theneo_verificationfunction (and several others) were redefined multiple times.Key improvements:
neo_verification,cehtr_resolver, andaa_resolverfrom multiple cells.output_portal(ipywidgets Output) to ensure it is shared consistently across all visualizations.Verification:
PR created automatically by Jules for task 1001432498825415985 started by @Sir-Ripley
Summary by Sourcery
Consolidate ODICE module functions into a single shared definition in the QAG_VerifiedNexus notebook to eliminate duplication and improve interactive behavior.
Enhancements:
Chores: