Skip to content

Solve Bug in Sitefinity having multiple sf-media-field in same designer view (document/videos) always change/update first sf-media-field control. Also bug present when having sf-auto-open-selector attribute present in sf-media-field always open first sf-media-field #2716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abhijeet2019 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solve Bug in Sitefinity having multiple sf-media-field in same designer view (document/videos) always change/update first sf-media-field control. Also bug present when having sf-auto-open-selector attribute present in sf-media-field always open first sf-media-field #2716

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99f5384
Solve bug multiple selector in same designer view
Abhijeet2019 Sep 30, 2022
7a31491
Update sf-media-field.js
Abhijeet2019 Sep 30, 2022
c5a99bd
Update sf-media-field.js
Abhijeet2019 Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions Telerik.Sitefinity.Frontend/client-components/fields/media-field/sf-media-field.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,9 @@
scope.mediaItemDeleted = false;

var autoOpenSelector = attrs.sfAutoOpenSelector !== undefined && attrs.sfAutoOpenSelector.toLowerCase() !== 'false';


var mediaElement = element;

var mediaType = sfMediaTypeResolver.get(scope.sfMediaType);

var getDateFromString = function (dateStr) {
Expand Down Expand Up @@ -277,7 +279,20 @@
scope.model.filterObject.status = attrs.sfMaster === 'true' || attrs.sfMaster === 'True' ? 'master' : 'live';
}

var mediaSelectorModalScope = angular.element('.mediaSelectorModal').scope();
var mediaSelector = angular.element('.mediaSelectorModal');

//Add below lines of code to solve multiple sf-media-field selector in same designer view
if (mediaElement && mediaElement.length > 0) {
var el = mediaElement[0].querySelector('.mediaSelectorModal');
if (el) {
var ngEl = angular.element(el);
if (ngEl) {
mediaSelector = ngEl;
}
}
}

var mediaSelectorModalScope = mediaSelector.scope();

if (mediaSelectorModalScope)
mediaSelectorModalScope.$openModalDialog();
Expand Down