cherry-pick: Only fetch if remote branch doesn't exist#169
Open
jerry-skydio wants to merge 1 commit intomainfrom
Open
cherry-pick: Only fetch if remote branch doesn't exist#169jerry-skydio wants to merge 1 commit intomainfrom
jerry-skydio wants to merge 1 commit intomainfrom
Conversation
Cherry-pick was updated to fetch if the branch doesn't exist, but this could fetch unnecessarily if the remote branch exists locally but namespaced in the remote. Make this more clear with 3 paths: - branch exists locally - branch doesn't exist but remote version of it does (no fetch needed) - neither of the above exists, will attempt to fetch
Collaborator
Author
|
Reviews in this chain: |
Collaborator
Author
2262b04 to
5547b89
Compare
Contributor
aaron-skydio
left a comment
There was a problem hiding this comment.
Does this work to repeatedly cherry-pick the same branch and get the new version each time? I do that a lot
Collaborator
Author
|
no 😞 i'll think about this some more since I agree its objectively more important to be able to pick up changes vs saving ~.5s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick was updated to fetch if the branch doesn't
exist, but this could fetch unnecessarily if the remote
branch exists locally but namespaced in the remote.
Make this more clear with 3 paths: