Add Flow Vault API coverage to call-rest-apis skill - #22
Open
jstjoe wants to merge 1 commit into
Open
Conversation
Adds the new Flow Vault API to the Skyflow REST APIs skill, matching how the Data, Detect, and Management APIs are already covered. - Add flow-vault.openapi.json: the complete Flow Vault OpenAPI 3.0 spec (43 paths across V2 vault management/records/query/tokens and V1 policies, roles, service accounts, users, workspaces, and auth). - Add flow-vault-api.md: a task-oriented guide with endpoints, curl examples, request/response bodies, and parameters for the key operations, plus notes on base URLs, authentication, redaction levels, token groups, hashings, and partial-success error handling. - Update SKILL.md: add Flow Vault rows to the API quick reference table, list the new spec, note Flow Vault's X-SKYFLOW-ACCOUNT-ID header and distinct base URLs, and extend the usage instructions. - Update CONTRIBUTING.md guide/spec mapping (and correct the stale vault-api.md entry to data-api.md). - Update the plugin README to mention Flow Vault. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JJ6x5iN7BXYFd6XNqh8yGb
Contributor
Author
|
Hey @claude code review please? |
Contributor
Author
|
Code review (requested by @jstjoe) Reviewed the diff on
One thing to be aware of (non-blocking):
Nothing else stood out. LGTM 🟢 Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds coverage for Skyflow's new Flow Vault API to the
call-rest-apisskill, so it sits alongside the existing Data, Detect, and Management API coverage. Source content came from theskyflow-fern-configrepo (used read-only as a source — no changes were made there).Changes
flow-vault.openapi.json(new) — the complete Flow Vault OpenAPI 3.0 spec, copied verbatim from the source repo. Covers 43 paths: V2 vault management, records, query, and tokens; V1 policies, roles, service accounts, users, workspaces, accounts, token exchange (STS), and authentication.flow-vault-api.md(new) — a task-oriented guide following the same format as the other*-api.mdguides. Includes endpoints,operationIds, copy-pastable curl examples, request/response bodies, and parameters for the key operations, plus sections on base URLs, authentication, redaction levels, token groups, hashings, and partial-success error handling.SKILL.md— added Flow Vault rows to the API quick reference table, listed the new spec under OpenAPI Specifications, noted Flow Vault's requiredX-SKYFLOW-ACCOUNT-IDheader and distinct base URLs, and extended the usage instructions.CONTRIBUTING.md— added theflow-vault-api.md→flow-vault.openapi.jsonmapping (and corrected the stalevault-api.mdentry todata-api.md).README.md(plugin) — updated thecall-rest-apisdescription to mention the Flow Vault API.Notes on Flow Vault specifics captured in the guide
skyvault.skyflowapis.comfor records/query/tokens,skyflowapis.comfor management/governance.X-SKYFLOW-ACCOUNT-IDis required on every request.plain_text,redacted) unlike the classic Data API.httpCode/error, HTTP 207).Verification
flow-vault.openapi.jsonis byte-identical to the source spec and parses as valid JSON (title "Flow Vault API", 43 paths).operationIds cited in the guide were cross-checked against the spec.skyflow-fern-configworking tree is unchanged.🤖 Generated with Claude Code
https://claude.ai/code/session_01JJ6x5iN7BXYFd6XNqh8yGb
Generated by Claude Code