Skip to content

test: disable the back/forward cache in the history response test - #231

Merged
suchintan merged 1 commit into
mainfrom
repo-sync/rustwright-cloud-220
Aug 14, 2026
Merged

test: disable the back/forward cache in the history response test#231
suchintan merged 1 commit into
mainfrom
repo-sync/rustwright-cloud-220

Conversation

@suchintan

Copy link
Copy Markdown
Member

@suchintan suchintan added the sync Automated cross-repository sync label Aug 14, 2026
@claude

claude Bot commented Aug 14, 2026

Copy link
Copy Markdown

Summary

Small, well-scoped test fix: test_history_navigation_returns_real_responses now launches its own browser with --disable-back-forward-cache instead of using the shared page fixture. This is the right fix — back/forward navigations restored from bfcache don't produce a real network response, so the test's assertions on status/url/json() were inherently racy against Chromium's bfcache heuristics. The custom-launch + try/finally: browser.close() pattern matches dozens of existing tests in this file (e.g. test_browser_close_is_idempotent_and_emits_disconnected_once), and the underlying bfcache-restore behavior itself already has dedicated Rust unit test coverage in src/lib.rs. Test-only change, no production code touched, no API/behavior/doc claims affected.

🔴 Critical Issues (0)

None.

🟡 Suggestions (0)

None.

📝 Minor / Style (1)
  • Other custom-launch tests in this file (e.g. around line 2761) don't explicitly call page.close() either since browser.close() tears down all pages — consistent here, just flagging that if a future refactor centralizes this pattern into a fixture (several tests now duplicate the launch/try/finally boilerplate), it'd reduce repetition. Not blocking.

LGTM.

@suchintan
suchintan merged commit 58be34b into main Aug 14, 2026
15 of 16 checks passed
@suchintan
suchintan deleted the repo-sync/rustwright-cloud-220 branch August 14, 2026 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sync Automated cross-repository sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant