You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Small, well-scoped test fix: test_history_navigation_returns_real_responses now launches its own browser with --disable-back-forward-cache instead of using the shared page fixture. This is the right fix — back/forward navigations restored from bfcache don't produce a real network response, so the test's assertions on status/url/json() were inherently racy against Chromium's bfcache heuristics. The custom-launch + try/finally: browser.close() pattern matches dozens of existing tests in this file (e.g. test_browser_close_is_idempotent_and_emits_disconnected_once), and the underlying bfcache-restore behavior itself already has dedicated Rust unit test coverage in src/lib.rs. Test-only change, no production code touched, no API/behavior/doc claims affected.
🔴 Critical Issues (0)
None.
🟡 Suggestions (0)
None.
📝 Minor / Style (1)
Other custom-launch tests in this file (e.g. around line 2761) don't explicitly call page.close() either since browser.close() tears down all pages — consistent here, just flagging that if a future refactor centralizes this pattern into a fixture (several tests now duplicate the launch/try/finally boilerplate), it'd reduce repetition. Not blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/Skyvern-AI/rustwright-cloud/pull/220