(Unfinished pull request) Customizable Expedition Background#19
Open
RepeatGitHub wants to merge 3 commits intoSlimeCubed:masterfrom
Open
(Unfinished pull request) Customizable Expedition Background#19RepeatGitHub wants to merge 3 commits intoSlimeCubed:masterfrom
RepeatGitHub wants to merge 3 commits intoSlimeCubed:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, I'll be real, I got no idea how to fully implement this by myself. I tried, but even if I somehow got everything right with no errors, it's still not completely done. (Check ExpeditionHooks for details.)
Anyway, the reason I made this is as a sort of suggestion to this mod so that users can customize which background is used in the Expedition menu, rather than ALWAYS making it randomized. (I did implement the logic so that it doesn't choose an MSC scene if MSC isn't enabled, and also still keeps the randomization function if the user doesn't choose a background.)