Adding all missing Signature Algoritms from XMLSignature#887
Open
hanndecl wants to merge 1 commit intoSmartBear:nextfrom
Open
Adding all missing Signature Algoritms from XMLSignature#887hanndecl wants to merge 1 commit intoSmartBear:nextfrom
hanndecl wants to merge 1 commit intoSmartBear:nextfrom
Conversation
Author
|
The merge request is currently still open, and I’m not entirely sure what the next steps are before it can be integrated. Could you please clarify if there are any remaining actions, reviews, or changes required from my side before we proceed with the merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds all missing signature algorithm constants from org.apache.xml.security.signature.XMLSignature to the algorithm selection dropdown built in the buildUI method of SignatureEntry.java.
Problem
The WSS SignatureEntry configuration UI only exposed a subset of the signature algorithms supported by the Apache XML Security library. Users who needed to sign SOAP messages with algorithms such as ECDSA variants, or HMAC variants were unable to select them through the UI, forcing workarounds or manual configuration.
Solution
The buildUI method in soapui/src/main/java/com/eviware/soapui/impl/wsdl/support/wss/entries/SignatureEntry.java has been updated to include all algorithm URI constants defined in org.apache.xml.security.signature.XMLSignature, ensuring full parity between what the Apache XML Security library supports and what SoapUI exposes to the user.
Changes
SignatureEntry.java — extended the signature algorithm list in buildUI to include all constants from XMLSignature (e.g. ECDSA variants, etc.)