Adding support for Hager WAASYS devices#2858
Open
JanJakubiszyn wants to merge 1 commit into
Open
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 73 files 516 suites 0s ⏱️ Results for commit d08ddc4. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against d08ddc4 |
Contributor
|
One way in which I think we could quickly simplify some of the Hager subdriver would be by require-ing some fields and functions from the main driver, and changing their inputs as necessary in the overriden driver, rather than rewriting everything completely from scratch. |
JanJakubiszyn
force-pushed
the
Hager_WAASYS_device_support
branch
from
46b4bc2 to
1373485
Compare
hcarter-775
reviewed
May 13, 2026
Contributor
hcarter-775
left a comment
hcarter-775
left a comment
There was a problem hiding this comment.
Thank you for implementing more of the pre-existing functionality. At this point, my main concern is with the way this device intersects with the main driver, all of which I've commented on at this point. As far as I can tell, we may not really have to interact with the main driver at all, and if so that would be my preference, to not include as many vendor checks in otherwise generic-ish code.
JanJakubiszyn
commented
May 18, 2026
JanJakubiszyn
force-pushed
the
Hager_WAASYS_device_support
branch
2 times, most recently
from
eae58ac to
ea664a3
Compare
hcarter-775
reviewed
May 22, 2026
| @@ -1,4 +1,4 @@ | |||
| -- Copyright © 2025 SmartThings, Inc. | |||
Contributor
Author
There was a problem hiding this comment.
Fixed. Thank you.
hcarter-775
reviewed
May 22, 2026
| device:set_field(fields.COMPONENT_TO_ENDPOINT_MAP, component_map, {persist = true}) | ||
| end | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Since I'm already making suggestions, let's remove the extra line?
Contributor
Author
There was a problem hiding this comment.
I have already removed 159th line. I'm not sure If this is still relevant.
JanJakubiszyn
force-pushed
the
Hager_WAASYS_device_support
branch
3 times, most recently
from
4fa8d9f to
d11f453
Compare
JanJakubiszyn
force-pushed
the
Hager_WAASYS_device_support
branch
from
ef0035d to
139d305
Compare
hcarter-775
approved these changes
Jun 1, 2026
Contributor
hcarter-775
left a comment
hcarter-775
left a comment
There was a problem hiding this comment.
There are two more minor comments that should be addressed imo, otherwise LGTM!
Contributor
|
And reminder, make sure to squash your commits before merging. Thanks! |
JanJakubiszyn
force-pushed
the
Hager_WAASYS_device_support
branch
from
2a5117d to
7a6bee8
Compare
JanJakubiszyn
force-pushed
the
Hager_WAASYS_device_support
branch
5 times, most recently
from
5559008 to
912c0c8
Compare
JanJakubiszyn
force-pushed
the
Hager_WAASYS_device_support
branch
from
912c0c8 to
d08ddc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests
Tests performed on the physical device.