Add BITUO TECHNIK OEM devices for the Zemismart manufacturer by script0803 · Pull Request #2986 · SmartThingsCommunity/SmartThingsEdgeDrivers

script0803 · 2026-05-20T06:43:22Z

Check all that apply

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Add BITUO TECHNIK OEM devices for the Zemismart manufacturer.

Summary of Completed Tests

test_zigbee_power_meter_1p_ZM
test_zigbee_power_meter_2p_ZM
test_zigbee_power_meter_3p_ZM

github-actions · 2026-05-20T06:44:40Z

Channel deleted.

github-actions · 2026-05-20T06:45:41Z

Test Results

73 files + 1 515 suites +4 0s ⏱️ ±0s
2 898 tests +31 2 898 ✅ +31 0 💤 ±0 0 ❌ ±0
4 794 runs +54 4 794 ✅ +54 0 💤 ±0 0 ❌ ±0

Results for commit ccb6da2. ± Comparison against base commit 3015ace.

This pull request removes 2 and adds 33 tests. Note that renamed tests count towards both.

Switch capability should send the appropriate commands
Switch child device: Set color temperature should send the appropriate commands

AC code report: fan=2 (high) and mode=4 (cool)
AC code report: fanonly mode (5)
AC code report: heat + medium fan + swing + setpoint 25.00 should emit all events
AC code report: invalid frame (b15_8 < 0xFE) should skip setpoint emit
AC code report: pending_on_mode + incoming off should NOT overwrite mode
AC code report: pwr=0 (off) should emit thermostatMode 'off'
AC code report: pwr=0xF (invalid) should skip thermostatMode update
AC code report: setpoint 0xFFFF (invalid marker) should skip setpoint emit
AC code report: unknown mode bits should fall back to 'heat'
Capability fanMode 'high' sends AC code with fan bits=2
…

♻️ This comment has been updated with latest results.

github-actions · 2026-05-20T06:45:43Z

File	Coverage
All files	`96%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/frient/EMIZB-151/init.lua	`93%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/lazy_load_subdriver.lua	`57%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/init.lua	`97%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/configurations.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/frient/init.lua	`93%`	✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against ccb6da2

cjswedes

LGTM, just a few formatting changes needed

cjswedes · 2026-05-22T15:05:02Z

Please add the copywrite header to the new test files

cjswedes · 2026-05-22T15:05:34Z

+  end
+)
+
+test.run_registered_tests()


nit: please have a trailing newline at the end of each of the test files

cjswedes · 2026-05-22T15:06:24Z

+test.register_message_test(
+    "ActivePower Report should be handled. Sensor value is in W, capability attribute value is in hectowatts",
+    {
+      {
+        channel = "zigbee",
+        direction = "receive",
+        message = { mock_device.id, ElectricalMeasurement.attributes.ActivePower:build_test_attr_report(mock_device,
+                                                                                                        27) },
+      },
+      {
+        channel = "capability",
+        direction = "send",
+        message = mock_device:generate_test_message("PhaseA", capabilities.powerMeter.power({ value = 27.0, unit = "W" }))
+      }
+    }
+)


Identical test can be removed.

Suggested change

test.register_message_test(

"ActivePower Report should be handled. Sensor value is in W, capability attribute value is in hectowatts",

{

{

channel = "zigbee",

direction = "receive",

message = { mock_device.id, ElectricalMeasurement.attributes.ActivePower:build_test_attr_report(mock_device,

27) },

},

{

channel = "capability",

direction = "send",

message = mock_device:generate_test_message("PhaseA", capabilities.powerMeter.power({ value = 27.0, unit = "W" }))

}

}

)

cjswedes · 2026-05-22T15:06:49Z

    end
  end
-  if string.find(device:get_model(), "SPM02") or string.find(device:get_model(), "SDM01W") then
+  if string.find(device:get_model(), "SPM02") or string.find(device:get_model(), "SDM01W") or string.find(device:get_model(), "SDM01-3Z1", 1, true)then


Suggested change

if string.find(device:get_model(), "SPM02") or string.find(device:get_model(), "SDM01W") or string.find(device:get_model(), "SDM01-3Z1", 1, true)then

if string.find(device:get_model(), "SPM02") or string.find(device:get_model(), "SDM01W") or string.find(device:get_model(), "SDM01-3Z1", 1, true) then

nand-nor

Just needs to formatting changes @cjswedes already requested but others LGTM

cbaumler · 2026-05-26T16:25:43Z

@cjswedes it looks like the formatting changes have been addressed. Could you give this a final review?

script0803 added 2 commits May 20, 2026 14:35

Add BituoTechnik's OEM device --Zemismart

13acc10

Add Zemismart device test file

b462de7

cbaumler requested review from aleclorimer, cjswedes and nand-nor May 21, 2026 20:43

cjswedes reviewed May 22, 2026

View reviewed changes

nand-nor approved these changes May 22, 2026

View reviewed changes

aleclorimer approved these changes May 22, 2026

View reviewed changes

Adjust the format

ccb6da2

cjswedes approved these changes May 26, 2026

View reviewed changes

cbaumler merged commit 8d9f3a7 into SmartThingsCommunity:main May 26, 2026
13 of 16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add BITUO TECHNIK OEM devices for the Zemismart manufacturer#2986

Add BITUO TECHNIK OEM devices for the Zemismart manufacturer#2986
cbaumler merged 3 commits into
SmartThingsCommunity:mainfrom
script0803:main

script0803 commented May 20, 2026

Uh oh!

github-actions Bot commented May 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 20, 2026 •

edited

Loading

Uh oh!

cjswedes left a comment

Uh oh!

cjswedes May 22, 2026

Uh oh!

cjswedes May 22, 2026

Uh oh!

cjswedes May 22, 2026

Uh oh!

cjswedes May 22, 2026

Uh oh!

nand-nor left a comment

Uh oh!

cbaumler commented May 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	if string.find(device:get_model(), "SPM02") or string.find(device:get_model(), "SDM01W") or string.find(device:get_model(), "SDM01-3Z1", 1, true)then
	if string.find(device:get_model(), "SPM02") or string.find(device:get_model(), "SDM01W") or string.find(device:get_model(), "SDM01-3Z1", 1, true) then

Conversation

script0803 commented May 20, 2026

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

github-actions Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjswedes left a comment

Choose a reason for hiding this comment

Uh oh!

cjswedes May 22, 2026

Choose a reason for hiding this comment

Uh oh!

cjswedes May 22, 2026

Choose a reason for hiding this comment

Uh oh!

cjswedes May 22, 2026

Choose a reason for hiding this comment

Uh oh!

cjswedes May 22, 2026

Choose a reason for hiding this comment

Uh oh!

nand-nor left a comment

Choose a reason for hiding this comment

Uh oh!

cbaumler commented May 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions Bot commented May 20, 2026 •

edited

Loading

github-actions Bot commented May 20, 2026 •

edited

Loading

github-actions Bot commented May 20, 2026 •

edited

Loading