Skip to content

Matter Thermostat: add setpoint step size override for Lennox#3026

Open
ctowns wants to merge 1 commit into
mainfrom
lennox-setpoint-step-override
Open

Matter Thermostat: add setpoint step size override for Lennox#3026
ctowns wants to merge 1 commit into
mainfrom
lennox-setpoint-step-override

Conversation

@ctowns

@ctowns ctowns commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Adds overrides to force step size to 0.5 degC for Lennox matter thermostat devices. These devices expect a setpoints in increments of 0.5 degC, and any value sent otherwise will be rounded to the nearest 0.5 deg step. This will make the UI more compatible with this device to prevent the need for the rounding.

Follows the same vendor override model that was already implemented in Matter Switch.

Summary of Completed Tests

Added a unit test (CGAI).
Pending partner test.

@github-actions

Copy link
Copy Markdown

@ctowns ctowns force-pushed the lennox-setpoint-step-override branch from 0317fba to aa17dab Compare June 11, 2026 19:24
@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

File Coverage
All files 87%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_handlers/capability_handlers.lua 86%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_handlers/attribute_handlers.lua 80%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_utils/fields.lua 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_utils/legacy_device_configuration.lua 84%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_utils/embedded_cluster_utils.lua 48%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_utils/utils.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_utils/device_configuration.lua 89%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 95%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against a01537e

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

Test Results

   73 files  ±0    516 suites  +1   0s ⏱️ ±0s
2 905 tests +1  2 905 ✅ +2  0 💤 ±0  0 ❌  - 1 
4 801 runs  +1  4 801 ✅ +2  0 💤 ±0  0 ❌  - 1 

Results for commit a01537e. ± Comparison against base commit 42a6a23.

♻️ This comment has been updated with latest results.

@ctowns ctowns force-pushed the lennox-setpoint-step-override branch from aa17dab to a01537e Compare June 11, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants