Fix/ci filtering and tests#155
Merged
Smartdevs17 merged 1 commit intoSmartdevs17:mainfrom Mar 27, 2026
Merged
Conversation
|
@Abidoyesimze Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
b715c79 to
f8a729f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What this PR does
This PR stabilizes CI after the filtering optimization work by fixing lint, TypeScript, and Jest regressions that were blocking the pipeline.
Changes included
Filtering performance hook
Updated src/hooks/useSubscriptionFilters.ts (already optimized) and kept it lint/type-safe.
Add Subscription typing fix
In src/screens/AddSubscriptionScreen.tsx, introduced a local form type extending SubscriptionFormData with priceError.
Fixed form handler key typing to support local validation fields without breaking domain types.
Wallet service unit tests fix
In src/services/tests/walletService.test.ts:
Removed problematic require(...) usage and cleaned imports.
Fixed TS private-field type collision (never intersection issue under TS 5.8).
Reworked provider mocking to use jest.spyOn(ethers.providers, 'JsonRpcProvider') for reliable behavior.
Applied Prettier/ESLint-compatible formatting.
Snapshot + lock alignment
Included updated contract test snapshots and lockfile changes required by local CI run.
Why this is needed
CI was failing with:
Prettier/ESLint errors
TypeScript errors (form type + test helper typing)
Jest failures in walletService.test.ts due to provider mock shape mismatch
This PR resolves all blocking errors and restores a passing pipeline.
Validation
Ran full local CI successfully:
npm run lint ✅ (warnings only, no errors)
npm run contracts:codegen:check ✅
npx tsc --noEmit ✅
npm run test ✅ (all suites pass)
npm run contracts:test ✅
npm run contracts:fmt ✅
npm run contracts:clippy ✅
closes #30