Skip to content

Fix/ci filtering and tests#155

Merged
Smartdevs17 merged 1 commit intoSmartdevs17:mainfrom
Abidoyesimze:fix/ci-filtering-and-tests
Mar 27, 2026
Merged

Fix/ci filtering and tests#155
Smartdevs17 merged 1 commit intoSmartdevs17:mainfrom
Abidoyesimze:fix/ci-filtering-and-tests

Conversation

@Abidoyesimze
Copy link
Copy Markdown
Contributor

Description

What this PR does
This PR stabilizes CI after the filtering optimization work by fixing lint, TypeScript, and Jest regressions that were blocking the pipeline.

Changes included

Filtering performance hook
Updated src/hooks/useSubscriptionFilters.ts (already optimized) and kept it lint/type-safe.
Add Subscription typing fix
In src/screens/AddSubscriptionScreen.tsx, introduced a local form type extending SubscriptionFormData with priceError.
Fixed form handler key typing to support local validation fields without breaking domain types.

Wallet service unit tests fix

In src/services/tests/walletService.test.ts:
Removed problematic require(...) usage and cleaned imports.
Fixed TS private-field type collision (never intersection issue under TS 5.8).
Reworked provider mocking to use jest.spyOn(ethers.providers, 'JsonRpcProvider') for reliable behavior.

Applied Prettier/ESLint-compatible formatting.

Snapshot + lock alignment

Included updated contract test snapshots and lockfile changes required by local CI run.
Why this is needed
CI was failing with:
Prettier/ESLint errors
TypeScript errors (form type + test helper typing)
Jest failures in walletService.test.ts due to provider mock shape mismatch
This PR resolves all blocking errors and restores a passing pipeline.

Validation

Ran full local CI successfully:
npm run lint ✅ (warnings only, no errors)
npm run contracts:codegen:check ✅
npx tsc --noEmit ✅
npm run test ✅ (all suites pass)
npm run contracts:test ✅
npm run contracts:fmt ✅
npm run contracts:clippy ✅

closes #30

@drips-wave
Copy link
Copy Markdown

drips-wave bot commented Mar 27, 2026

@Abidoyesimze Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Abidoyesimze Abidoyesimze force-pushed the fix/ci-filtering-and-tests branch from b715c79 to f8a729f Compare March 27, 2026 19:57
@Smartdevs17 Smartdevs17 merged commit 8b3b867 into Smartdevs17:main Mar 27, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

⚡ Optimize useMemo dependencies in HomeScreen

2 participants