Skip to content

Fix pre-existing oracle TypeScript errors#170

Merged
Smartdevs17 merged 1 commit intoSmartdevs17:mainfrom
josephchimebuka:chore/fix-oracle-type-errors
Mar 30, 2026
Merged

Fix pre-existing oracle TypeScript errors#170
Smartdevs17 merged 1 commit intoSmartdevs17:mainfrom
josephchimebuka:chore/fix-oracle-type-errors

Conversation

@josephchimebuka
Copy link
Copy Markdown
Contributor

Summary

  • fix the oracle service to instantiate and pass PriceHistoryService into the aggregator correctly
  • update the aggregator to use the existing CircuitBreaker API
  • fix the remaining contract updater health-check typing issues

Why

These are pre-existing unrelated TypeScript errors outside the issue bundle PR. This keeps that work in a separate cleanup PR.

Testing

  • cd oracle && pnpm exec tsc --noEmit

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 30, 2026

@josephchimebuka is attempting to deploy a commit to the smartdevs17's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave
Copy link
Copy Markdown

drips-wave bot commented Mar 30, 2026

Hey @josephchimebuka! 👋 It looks like this PR isn't linked to any issue.

If this PR is for one of the issues assigned to you as part of a Wave, please link it to ensure your contribution is tracked properly. You can do this by adding a keyword to the PR description (e.g., Closes #123), or by clicking a button below:

Issue Title
#34 Feature: Split health check into liveness and readiness probes Link to this issue
#43 Feature: Make Oracle transaction fee configurable for network congestion Link to this issue
#47 Fix: Use consistent logging (replace console.error with logger) Link to this issue
#51 Add GitHub issue and PR templates Link to this issue

ℹ️ Learn more about linking PRs to issues

@josephchimebuka josephchimebuka force-pushed the chore/fix-oracle-type-errors branch from dcab6ed to 33c4b9a Compare March 30, 2026 07:16
@Smartdevs17 Smartdevs17 merged commit e3c3e31 into Smartdevs17:main Mar 30, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants