Con 1896 jobs progress #95

az-smartling · 2025-12-03T13:30:26Z

gemini-code-assist · 2025-12-03T13:30:56Z

Summary of Changes

Hello @az-smartling, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Smartling CLI by adding a new jobs command, specifically enabling users to track the progress of their translation jobs. Concurrently, it undertakes a refactoring effort to standardize how output parameters are handled across different commands, ensuring a more consistent and maintainable codebase for future development. These changes aim to provide more utility and a better user experience for managing translation workflows.

Highlights

New jobs progress Command: Introduced a new jobs command with a progress subcommand, allowing users to check the status and word count of translation jobs by their UID or name.
Centralized Output Parameter Handling: Refactored and centralized the logic for resolving output parameters (format, mode, template) into a new cmd/helpers/resolve/output_params.go module, improving consistency across various CLI commands.
Dependency Updates: Updated core dependencies, including github.com/Smartling/api-sdk-go and several golang.org/x modules, to their latest versions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new jobs progress command to check the status of translation jobs. It also includes a significant refactoring to centralize the handling of output parameters. The refactoring is well-executed and improves code structure. However, the implementation of the new jobs progress command has some areas for improvement, including code duplication, redundant checks, and dead code. I've left specific comments with suggestions to address these points.

cmd/jobs/progress/cmd_progress.go

services/jobs/run_progress.go

dimitrystd · 2025-12-24T16:47:50Z

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

…d build process.

dimitrystd · 2025-12-24T17:22:48Z

cmd/jobs/progress/cmd_progress.go

+If multiple jobs share the same name, the most recent active job (not Canceled or Closed)
+will be selected.
+
+Output Formats:


@az-smartling I have updated the documentation for two new commands. Please review the new texts, but I want to draw your attention to these output formats. Of course, this text was generated by LLM, but I'm not sure if we should hard-code it into this command. Perhaps we should make this text a shared const and reuse it in all new commands. What are your thoughts on it?

Will be good to standardize output related variable for all commands. And move them to root command.
We have
--output-format (simple, json etc)
--output-template ({{.File}}, {{.Language}} ...)
--output-mode (dynamic, static) - only for mt command

My original comment was about two predefined output styles\templates: simple and json. If we can generalize the code and keep it in the root command, then it is great.
But I didn't get the output-mode (dynamic, static). What is it? And why mt requires a dedicated implementation.

For some commands we have table output.

smartling-cli/tests/post-release-tests/snapshots/help_mt_translate.snapshot

Line 38 in 9bf54b7

--output string Output format: table, json, simple (default "simple")

We should discuss this.

dimitrystd · 2025-12-24T17:25:08Z

docs/smartling-cli_jobs.md

@az-smartling I didn't generate the updated documentation. I plan to do this in the master branch when we will merge all related PRs.

I've generated docs and will generate it on master too after merge.

Makefile

# Conflicts: # go.mod # go.sum

dimitrystd · 2026-01-25T01:12:12Z

cmd/jobs/progress/run.go

+
+	if progressOutput.TranslationJobUID == "" {
+		rlog.Infof("no jobs found for given translationJobUid or translationJobName: %s", params.JobIDOrName)
+		return nil


What is the exit code that will be returned in this case? I believe it should be non-zero.

Changed to return error

dimitrystd · 2026-01-25T01:13:21Z

services/jobs/run_progress.go

+		}
+	}
+	if translationJobUID == "" {
+		return ProgressOutput{}, nil


Return some error here.

Suggested change

return ProgressOutput{}, nil

return ProgressOutput{}, ErrJobNotFound

dimitrystd · 2026-01-25T01:18:33Z

cmd/jobs/progress/cmd_progress.go

+If multiple jobs share the same name, the most recent active job (not Canceled or Closed)
+will be selected.
+
+Output Formats:


My original comment was about two predefined output styles\templates: simple and json. If we can generalize the code and keep it in the root command, then it is great.
But I didn't get the output-mode (dynamic, static). What is it? And why mt requires a dedicated implementation.

dimitrystd · 2026-01-25T01:20:02Z

services/jobs/run_progress.go

+type ProgressParams struct {
+	AccountUID  api.AccountUID
+	ProjectUID  string
+	JobIDOrName string


Suggested change

JobIDOrName string

JobUIDOrName string

az-smartling added 2 commits December 3, 2025 14:27

CON-1896 jobs progress

1400fbc

go mod tidy

33a8474

az-smartling mentioned this pull request Dec 3, 2025

CON-1896 jobs progress Smartling/api-sdk-go#24

Open

gemini-code-assist bot reviewed Dec 3, 2025

View reviewed changes

az-smartling added 4 commits December 3, 2025 14:33

updated md docs

a01e411

CR changes

9385101

tests

041b889

CR changes

217a008

az-smartling requested a review from dimitrystd December 3, 2025 16:56

added job test to Makefile

a5b6a01

dimitrystd added 2 commits December 24, 2025 12:19

CON-1896 Update command descriptions.

e7d6c3c

Enhanced CLAUDE.md. Updated Makefile for module vendoring and improve…

df90e7c

…d build process.

dimitrystd reviewed Dec 24, 2025

View reviewed changes

dimitrystd and others added 6 commits December 24, 2025 13:20

Fix cmd_locates_test.

8d3c4e3

Add 'Run Tests' stage to Jenkins pipeline with JUnit reporting

bf5a566

used go mod download

2b96749

updated do.mod

6aa5283

added ErrJobNotFound

44ec26b

updated go.sum

313a0bf

az-smartling requested a review from dimitrystd January 22, 2026 19:36

az-smartling added 3 commits January 23, 2026 10:17

updated docs

cb48c06

Merge branch 'master' into CON-1896_jobs_progress

73b064f

# Conflicts: # go.mod # go.sum

updated go.mod

6eb57d0

dimitrystd reviewed Jan 25, 2026

View reviewed changes

updated go.mod, renaming, retund error if job not found

4736a1e

az-smartling requested a review from dimitrystd January 26, 2026 11:55

	return ProgressOutput{}, nil
	return ProgressOutput{}, ErrJobNotFound

Con 1896 jobs progress #95

Are you sure you want to change the base?

Con 1896 jobs progress #95

Uh oh!

Conversation

az-smartling commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Dec 3, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dimitrystd commented Dec 24, 2025

Code review

Uh oh!

Choose a reason for hiding this comment

Uh oh!

az-smartling Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

az-smartling commented Dec 3, 2025 •

edited

Loading

az-smartling Jan 23, 2026 •

edited

Loading